tests - add test for out of workspace watchers

Benjamin Pasero · Benjamin Pasero · commit 11fd274e2e3e · 2020-02-21T11:08:02.000+01:00
diff --git a/src/vs/workbench/services/editor/test/browser/editorService.test.ts b/src/vs/workbench/services/editor/test/browser/editorService.test.ts
@@ -896,4 +896,26 @@ suite('EditorService', () => {
 			Event.once(editorService.onDidActiveEditorChange)(c);
 		});
 	}
+
+	test('file watcher gets installed for out of workspace files', async function () {
+		const [part, service, testInstantiationService, accessor] = createEditorService();
+
+		const input1 = testInstantiationService.createInstance(TestEditorInput, URI.parse('file://resource1-openside'));
+		const input2 = testInstantiationService.createInstance(TestEditorInput, URI.parse('file://resource2-openside'));
+
+		await part.whenRestored;
+
+		await service.openEditor(input1, { pinned: true });
+		assert.equal(accessor.fileService.watches.length, 1);
+		assert.equal(accessor.fileService.watches[0].toString(), input1.resource.toString());
+
+		const editor = await service.openEditor(input2, { pinned: true });
+		assert.equal(accessor.fileService.watches.length, 1);
+		assert.equal(accessor.fileService.watches[0].toString(), input2.resource.toString());
+
+		await editor?.group?.closeAllEditors();
+		assert.equal(accessor.fileService.watches.length, 0);
+
+		part.dispose();
+	});
 });
diff --git a/src/vs/workbench/test/browser/workbenchTestServices.ts b/src/vs/workbench/test/browser/workbenchTestServices.ts
@@ -739,7 +739,14 @@ export class TestFileService implements IFileService {
 	}
 
 	del(_resource: URI, _options?: { useTrash?: boolean, recursive?: boolean }): Promise<void> { return Promise.resolve(); }
-	watch(_resource: URI): IDisposable { return Disposable.None; }
+
+	readonly watches: URI[] = [];
+	watch(_resource: URI): IDisposable {
+		this.watches.push(_resource);
+
+		return toDisposable(() => this.watches.splice(this.watches.indexOf(_resource), 1));
+	}
+
 	getWriteEncoding(_resource: URI): IResourceEncoding { return { encoding: 'utf8', hasBOM: false }; }
 	dispose(): void { }
 }
