Skip to content

Commit 11b364a

Browse files
committed
👯‍♂️ remove WinJS.Promise#cancel and cancel callback microsoft#56137
1 parent 1b2aab7 commit 11b364a

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

src/vs/base/common/winjs.base.d.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,12 @@
77
export type ErrorCallback = (error: any) => void;
88

99
export class Promise<T = any> {
10-
constructor(
11-
executor: (
12-
resolve: (value: T | PromiseLike<T>) => void,
13-
reject: (reason: any) => void) => void,
14-
oncancel?: () => void);
10+
constructor(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason: any) => void) => void);
1511

1612
public then<TResult1 = T, TResult2 = never>(
1713
onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | null,
1814
onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null): Promise<TResult1 | TResult2>;
1915

20-
public cancel(): void;
2116

2217
public static as(value: null): Promise<null>;
2318
public static as(value: undefined): Promise<undefined>;

src/vs/monaco.d.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,12 @@ declare namespace monaco {
3939

4040

4141
export class Promise<T = any> {
42-
constructor(
43-
executor: (
44-
resolve: (value: T | PromiseLike<T>) => void,
45-
reject: (reason: any) => void) => void,
46-
oncancel?: () => void);
42+
constructor(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason: any) => void) => void);
4743

4844
public then<TResult1 = T, TResult2 = never>(
4945
onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | null,
5046
onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null): Promise<TResult1 | TResult2>;
5147

52-
public cancel(): void;
5348

5449
public static as(value: null): Promise<null>;
5550
public static as(value: undefined): Promise<undefined>;

0 commit comments

Comments
 (0)