Re microsoft#96433

rebornix · rebornix · commit 118da97dc8be · 2020-05-13T12:53:03.000-07:00
diff --git a/extensions/vscode-notebook-tests/src/notebook.test.ts b/extensions/vscode-notebook-tests/src/notebook.test.ts
@@ -329,7 +329,7 @@ suite('metadata', () => {
 		await waitFor(500);
 		assert.equal(vscode.notebook.activeNotebookEditor !== undefined, true, 'notebook first');
 		assert.equal(vscode.notebook.activeNotebookEditor!.document.metadata.custom['testMetadata'] as boolean, false);
-		assert.equal(vscode.notebook.activeNotebookEditor!.selection?.metadata.custom['testCellMetadata'] as boolean, true);
+		assert.equal(vscode.notebook.activeNotebookEditor!.selection?.metadata.custom!['testCellMetadata'] as number, 123);
 		assert.equal(vscode.notebook.activeNotebookEditor!.selection?.language, 'typescript');
 	});
 });
diff --git a/extensions/vscode-notebook-tests/src/notebookTestMain.ts b/extensions/vscode-notebook-tests/src/notebookTestMain.ts
@@ -29,7 +29,7 @@ export function activate(context: vscode.ExtensionContext): any {
 						cellKind: vscode.CellKind.Code,
 						outputs: [],
 						metadata: {
-							custom: { testCellMetadata: true }
+							custom: { testCellMetadata: 123 }
 						}
 					}
 				]
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -1594,7 +1594,7 @@ declare module 'vscode' {
 		/**
 		 * Additional attributes of a cell metadata.
 		 */
-		[key: string]: any;
+		custom?: { [key: string]: any };
 	}
 
 	export interface NotebookCell {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export function activate(context: vscode.ExtensionContext): any {`
`29`	`29`	`cellKind: vscode.CellKind.Code,`
`30`	`30`	`outputs: [],`
`31`	`31`	`metadata: {`
`32`		`- custom: { testCellMetadata: true }`
	`32`	`+ custom: { testCellMetadata: 123 }`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1594,7 +1594,7 @@ declare module 'vscode' {`
`1594`	`1594`	`/**`
`1595`	`1595`	`* Additional attributes of a cell metadata.`
`1596`	`1596`	`*/`
`1597`		`- [key: string]: any;`
	`1597`	`+ custom?: { [key: string]: any };`
`1598`	`1598`	`}`
`1599`	`1599`
`1600`	`1600`	`export interface NotebookCell {`