Skip to content

Commit 0ed3e19

Browse files
joaomorenojoaomoreno
committed
make product build scripts stop when any command fails
1 parent 56ad4b3 commit 0ed3e19

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

‎build/tfs/product-build.yml‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ phases:
2020
versionSpec: "1.3.2"
2121

2222
- powershell: |
23+
$ErrorActionPreference = "Stop"
2324
"machine monacotools.visualstudio.com password $(VSO_PAT)" | Out-File "$env:USERPROFILE\_netrc" -Encoding ASCII
2425
$env:npm_config_arch="$(VSCODE_ARCH)"
2526
$env:CHILD_CONCURRENCY="1"
@@ -32,12 +33,14 @@ phases:
3233
node build/lib/builtInExtensions.js
3334
3435
- powershell: |
36+
$ErrorActionPreference = "Stop"
3537
$env:VSCODE_MIXIN_PASSWORD="$(VSCODE_MIXIN_PASSWORD)"
3638
npm run gulp -- "vscode-win32-$(VSCODE_ARCH)-min"
3739
npm run gulp -- "vscode-win32-$(VSCODE_ARCH)-copy-inno-updater"
3840
name: build
3941
4042
- powershell: |
43+
$ErrorActionPreference = "Stop"
4144
npm run gulp -- "electron-$(VSCODE_ARCH)"
4245
.\scripts\test.bat --build --tfs
4346
# yarn smoketest -- --build "$(agent.builddirectory)\VSCode-win32-$(VSCODE_ARCH)"
@@ -123,6 +126,7 @@ phases:
123126
SessionTimeout: 120
124127

125128
- powershell: |
129+
$ErrorActionPreference = "Stop"
126130
npm run gulp -- "vscode-win32-$(VSCODE_ARCH)-archive" "vscode-win32-$(VSCODE_ARCH)-setup"
127131
128132
- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
@@ -205,6 +209,7 @@ phases:
205209
SessionTimeout: 120
206210

207211
- powershell: |
212+
$ErrorActionPreference = "Stop"
208213
$Repo = "$(pwd)"
209214
$Root = "$Repo\.."
210215
$Exe = "$Repo\.build\win32-$(VSCODE_ARCH)\setup\VSCodeSetup.exe"
@@ -244,6 +249,7 @@ phases:
244249
versionSpec: "1.3.2"
245250

246251
- script: |
252+
set -e
247253
export npm_config_arch="$(VSCODE_ARCH)"
248254
if [[ "$(VSCODE_ARCH)" == "ia32" ]]; then
249255
export PKG_CONFIG_PATH="/usr/lib/i386-linux-gnu/pkgconfig"
@@ -258,16 +264,19 @@ phases:
258264
node build/lib/builtInExtensions.js
259265
260266
- script: |
267+
set -e
261268
VSCODE_MIXIN_PASSWORD="$(VSCODE_MIXIN_PASSWORD)" npm run gulp -- vscode-linux-$(VSCODE_ARCH)-min
262269
name: build
263270
264271
- script: |
272+
set -e
265273
npm run gulp -- "electron-$(VSCODE_ARCH)"
266274
DISPLAY=:10 ./scripts/test.sh --build --tfs
267275
# yarn smoketest -- --build "$(agent.builddirectory)/VSCode-linux-$(VSCODE_ARCH)"
268276
name: test
269277
270278
- script: |
279+
set -e
271280
npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-deb"
272281
npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-rpm"
273282
#npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-snap"
@@ -296,6 +305,7 @@ phases:
296305
versionSpec: "1.3.2"
297306

298307
- script: |
308+
set -e
299309
export npm_config_arch="$(VSCODE_ARCH)"
300310
if [[ "$(VSCODE_ARCH)" == "ia32" ]]; then
301311
export PKG_CONFIG_PATH="/usr/lib/i386-linux-gnu/pkgconfig"
@@ -310,16 +320,19 @@ phases:
310320
node build/lib/builtInExtensions.js
311321
312322
- script: |
323+
set -e
313324
VSCODE_MIXIN_PASSWORD="$(VSCODE_MIXIN_PASSWORD)" npm run gulp -- vscode-linux-$(VSCODE_ARCH)-min
314325
name: build
315326
316327
- script: |
328+
set -e
317329
npm run gulp -- "electron-$(VSCODE_ARCH)"
318330
DISPLAY=:10 ./scripts/test.sh --build --tfs
319331
# yarn smoketest -- --build "$(agent.builddirectory)/VSCode-linux-$(VSCODE_ARCH)"
320332
name: test
321333
322334
- script: |
335+
set -e
323336
npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-deb"
324337
npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-rpm"
325338
#npm run gulp -- "vscode-linux-$(VSCODE_ARCH)-build-snap"
@@ -345,6 +358,7 @@ phases:
345358
versionSpec: "1.3.2"
346359

347360
- script: |
361+
set -e
348362
echo "machine monacotools.visualstudio.com password $(VSO_PAT)" > ~/.netrc
349363
yarn
350364
npm run gulp -- hygiene
@@ -354,18 +368,21 @@ phases:
354368
node build/lib/builtInExtensions.js
355369
356370
- script: |
371+
set -e
357372
VSCODE_MIXIN_PASSWORD="$(VSCODE_MIXIN_PASSWORD)" \
358373
AZURE_STORAGE_ACCESS_KEY="$(AZURE_STORAGE_ACCESS_KEY)" \
359374
npm run gulp -- vscode-darwin-min upload-vscode-sourcemaps
360375
name: build
361376
362377
- script: |
378+
set -e
363379
./scripts/test.sh --build --tfs
364380
APP_NAME="`ls $(agent.builddirectory)/VSCode-darwin | head -n 1`"
365381
# yarn smoketest -- --build "$(agent.builddirectory)/VSCode-darwin/$APP_NAME"
366382
name: test
367383
368384
- script: |
385+
set -e
369386
# archive the unsigned build
370387
pushd ../VSCode-darwin && zip -r -X -y ../VSCode-darwin-unsigned.zip * && popd
371388

0 commit comments

Comments
 (0)