actions - remove some unused event/context from run()

Benjamin Pasero · Benjamin Pasero · commit 0e70726bf900 · 2020-05-11T09:38:17.000+02:00
diff --git a/src/vs/base/browser/ui/tree/treeDefaults.ts b/src/vs/base/browser/ui/tree/treeDefaults.ts
@@ -13,7 +13,7 @@ export class CollapseAllAction<TInput, T, TFilterData = void> extends Action {
 		super('vs.tree.collapse', nls.localize('collapse all', "Collapse All"), 'collapse-all', enabled);
 	}
 
-	async run(context?: any): Promise<any> {
+	async run(): Promise<any> {
 		this.viewer.collapseAll();
 		this.viewer.setSelection([]);
 		this.viewer.setFocus([]);
diff --git a/src/vs/workbench/contrib/localizations/browser/localizationsActions.ts b/src/vs/workbench/contrib/localizations/browser/localizationsActions.ts
@@ -46,7 +46,7 @@ export class ConfigureLocaleAction extends Action {
 			.concat({ label: localize('installAdditionalLanguages', "Install additional languages...") });
 	}
 
-	public async run(event?: any): Promise<void> {
+	public async run(): Promise<void> {
 		const languageOptions = await this.getLanguageOptions();
 		const currentLanguageIndex = firstIndex(languageOptions, l => l.label === language);
 
diff --git a/src/vs/workbench/contrib/tasks/browser/runAutomaticTasks.ts b/src/vs/workbench/contrib/tasks/browser/runAutomaticTasks.ts
@@ -145,7 +145,7 @@ export class ManageAutomaticTaskRunning extends Action {
 		super(id, label);
 	}
 
-	public async run(event?: any): Promise<any> {
+	public async run(): Promise<any> {
 		const allowItem: IQuickPickItem = { label: nls.localize('workbench.action.tasks.allowAutomaticTasks', "Allow Automatic Tasks in Folder") };
 		const disallowItem: IQuickPickItem = { label: nls.localize('workbench.action.tasks.disallowAutomaticTasks', "Disallow Automatic Tasks in Folder") };
 		const value = await this.quickInputService.pick([allowItem, disallowItem], { canPickMany: false });
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalActions.ts b/src/vs/workbench/contrib/terminal/browser/terminalActions.ts
@@ -236,7 +236,7 @@ export class SplitTerminalAction extends Action {
 		super(id, label, SplitTerminalAction.HORIZONTAL_CLASS);
 	}
 
-	public async run(event?: any): Promise<any> {
+	public async run(): Promise<any> {
 		await this._terminalService.doWithActiveInstance(async t => {
 			const cwd = await getCwdForSplit(this._terminalService.configHelper, t, this._workspaceContextService.getWorkspace().folders, this._commandService);
 			if (cwd === undefined) {
diff --git a/src/vs/workbench/contrib/terminal/electron-browser/terminalRemote.ts b/src/vs/workbench/contrib/terminal/electron-browser/terminalRemote.ts
@@ -29,7 +29,7 @@ export class CreateNewLocalTerminalAction extends Action {
 		super(id, label);
 	}
 
-	public run(event?: any): Promise<any> {
+	public run(): Promise<any> {
 		const instance = this.terminalService.createTerminal({ cwd: URI.file(homedir()) });
 		if (!instance) {
 			return Promise.resolve(undefined);

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ export class CollapseAllAction<TInput, T, TFilterData = void> extends Action {`
`13`	`13`	`super('vs.tree.collapse', nls.localize('collapse all', "Collapse All"), 'collapse-all', enabled);`
`14`	`14`	`}`
`15`	`15`
`16`		`- async run(context?: any): Promise<any> {`
	`16`	`+ async run(): Promise<any> {`
`17`	`17`	`this.viewer.collapseAll();`
`18`	`18`	`this.viewer.setSelection([]);`
`19`	`19`	`this.viewer.setFocus([]);`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export class ConfigureLocaleAction extends Action {`
`46`	`46`	`.concat({ label: localize('installAdditionalLanguages', "Install additional languages...") });`
`47`	`47`	`}`
`48`	`48`
`49`		`- public async run(event?: any): Promise<void> {`
	`49`	`+ public async run(): Promise<void> {`
`50`	`50`	`const languageOptions = await this.getLanguageOptions();`
`51`	`51`	`const currentLanguageIndex = firstIndex(languageOptions, l => l.label === language);`
`52`	`52`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ export class ManageAutomaticTaskRunning extends Action {`
`145`	`145`	`super(id, label);`
`146`	`146`	`}`
`147`	`147`
`148`		`- public async run(event?: any): Promise<any> {`
	`148`	`+ public async run(): Promise<any> {`
`149`	`149`	`const allowItem: IQuickPickItem = { label: nls.localize('workbench.action.tasks.allowAutomaticTasks', "Allow Automatic Tasks in Folder") };`
`150`	`150`	`const disallowItem: IQuickPickItem = { label: nls.localize('workbench.action.tasks.disallowAutomaticTasks', "Disallow Automatic Tasks in Folder") };`
`151`	`151`	`const value = await this.quickInputService.pick([allowItem, disallowItem], { canPickMany: false });`
Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ export class SplitTerminalAction extends Action {`
`236`	`236`	`super(id, label, SplitTerminalAction.HORIZONTAL_CLASS);`
`237`	`237`	`}`
`238`	`238`
`239`		`- public async run(event?: any): Promise<any> {`
	`239`	`+ public async run(): Promise<any> {`
`240`	`240`	`await this._terminalService.doWithActiveInstance(async t => {`
`241`	`241`	`const cwd = await getCwdForSplit(this._terminalService.configHelper, t, this._workspaceContextService.getWorkspace().folders, this._commandService);`
`242`	`242`	`if (cwd === undefined) {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export class CreateNewLocalTerminalAction extends Action {`
`29`	`29`	`super(id, label);`
`30`	`30`	`}`
`31`	`31`
`32`		`- public run(event?: any): Promise<any> {`
	`32`	`+ public run(): Promise<any> {`
`33`	`33`	`const instance = this.terminalService.createTerminal({ cwd: URI.file(homedir()) });`
`34`	`34`	`if (!instance) {`
`35`	`35`	`return Promise.resolve(undefined);`