Mac: Recent files should be split into files and folders (fixes microsoft#4167)

Benjamin Pasero · Benjamin Pasero · commit 0e1ed936412a · 2016-03-24T17:12:15.000+01:00
diff --git a/src/vs/workbench/electron-main/menus.ts b/src/vs/workbench/electron-main/menus.ts
@@ -224,7 +224,7 @@ export class VSCodeMenu {
 		}
 
 		let mru = this.getOpenedPathsList();
-		if (isFile || platform.isMacintosh /* on mac we don't treat files any different from folders */) {
+		if (isFile) {
 			mru.files.unshift(path);
 			mru.files = arrays.distinct(mru.files, (f) => platform.isLinux ? f : f.toLowerCase());
 		} else {
diff --git a/src/vs/workbench/electron-main/windows.ts b/src/vs/workbench/electron-main/windows.ts
@@ -719,7 +719,7 @@ export class WindowsManager {
 		recentPaths = arrays.distinct(recentPaths);
 
 		// Make sure it is bounded
-		return recentPaths.slice(0, 10);
+		return recentPaths.slice(0, 20 /* max 10 files, 10 folders */);
 	}
 
 	private toIPath(anyPath: string, ignoreFileNotFound?: boolean, gotoLineMode?: boolean): window.IPath {

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ export class VSCodeMenu {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`let mru = this.getOpenedPathsList();`
`227`		`- if (isFile \|\| platform.isMacintosh /* on mac we don't treat files any different from folders */) {`
	`227`	`+ if (isFile) {`
`228`	`228`	`mru.files.unshift(path);`
`229`	`229`	`mru.files = arrays.distinct(mru.files, (f) => platform.isLinux ? f : f.toLowerCase());`
`230`	`230`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -719,7 +719,7 @@ export class WindowsManager {`
`719`	`719`	`recentPaths = arrays.distinct(recentPaths);`
`720`	`720`
`721`	`721`	`// Make sure it is bounded`
`722`		`- return recentPaths.slice(0, 10);`
	`722`	`+ return recentPaths.slice(0, 20 /* max 10 files, 10 folders */);`
`723`	`723`	`}`
`724`	`724`
`725`	`725`	`private toIPath(anyPath: string, ignoreFileNotFound?: boolean, gotoLineMode?: boolean): window.IPath {`