proxy authentication does not work on 1.49 (microsoft#106434) (microsoft#106490)

Benjamin Pasero · web-flow · commit 0bff53bec8ea · 2020-09-11T10:52:25.000-07:00
diff --git a/src/vs/code/electron-main/auth.ts b/src/vs/code/electron-main/auth.ts
@@ -92,9 +92,9 @@ export class ProxyAuthHandler extends Disposable {
 			if (channel === 'vscode:proxyAuthResponse') {
 				const { username, password } = credentials;
 				cb(username, password);
+				win.removeListener('close', onWindowClose);
+				win.close();
 			}
-			win.removeListener('close', onWindowClose);
-			win.close();
 		});
 		win.loadURL(url);
 	}

Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,9 @@ export class ProxyAuthHandler extends Disposable {`
`92`	`92`	`if (channel === 'vscode:proxyAuthResponse') {`
`93`	`93`	`const { username, password } = credentials;`
`94`	`94`	`cb(username, password);`
	`95`	`+ win.removeListener('close', onWindowClose);`
	`96`	`+ win.close();`
`95`	`97`	`}`
`96`		`- win.removeListener('close', onWindowClose);`
`97`		`- win.close();`
`98`	`98`	`});`
`99`	`99`	`win.loadURL(url);`
`100`	`100`	`}`