Add workaround for parameter hints overflow with electron 6

mjbvz · mjbvz · commit 0a335ea664e6 · 2019-09-14T09:17:10.000-07:00
Fixes microsoft#79690 Manually sync size of widget contents with parent
diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts
@@ -332,7 +332,12 @@ export class ParameterHintsWidget extends Disposable implements IContentWidget,
 
 	private updateMaxHeight(): void {
 		const height = Math.max(this.editor.getLayoutInfo().height / 4, 250);
-		this.element.style.maxHeight = `${height}px`;
+		const maxHeight = `${height}px`;
+		this.element.style.maxHeight = maxHeight;
+		const wrapper = this.element.getElementsByClassName('wrapper') as HTMLCollectionOf<HTMLElement>;
+		if (wrapper.length) {
+			wrapper[0].style.maxHeight = maxHeight;
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -332,7 +332,12 @@ export class ParameterHintsWidget extends Disposable implements IContentWidget,`
`332`	`332`
`333`	`333`	`private updateMaxHeight(): void {`
`334`	`334`	`const height = Math.max(this.editor.getLayoutInfo().height / 4, 250);`
`335`		- this.element.style.maxHeight = `${height}px`;
	`335`	+ const maxHeight = `${height}px`;
	`336`	`+ this.element.style.maxHeight = maxHeight;`
	`337`	`+ const wrapper = this.element.getElementsByClassName('wrapper') as HTMLCollectionOf<HTMLElement>;`
	`338`	`+ if (wrapper.length) {`
	`339`	`+ wrapper[0].style.maxHeight = maxHeight;`
	`340`	`+ }`
`336`	`341`	`}`
`337`	`342`	`}`
`338`	`343`