web - do not loose state on unload

Benjamin Pasero · Benjamin Pasero · commit 0921202c2cb0 · 2019-08-14T07:59:53.000+02:00
diff --git a/src/vs/platform/storage/browser/storageService.ts b/src/vs/platform/storage/browser/storageService.ts
@@ -144,8 +144,10 @@ export class BrowserStorageService extends Disposable implements IStorageService
 		// Signal as event so that clients can still store data
 		this._onWillSaveState.fire({ reason: WillSaveStateReason.SHUTDOWN });
 
-		// Close DBs
-		this.globalStorage.close();
-		this.workspaceStorage.close();
+		// We explicitly do not close our DBs because writing data onBeforeUnload()
+		// can result in unexpected results. Namely, it seems that - even though this
+		// operation is async - sometimes it is being triggered on unload and
+		// succeeds. Often though, the DBs turn out to be empty because the write
+		// never had a chance to complete.
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,10 @@ export class BrowserStorageService extends Disposable implements IStorageService`
`144`	`144`	`// Signal as event so that clients can still store data`
`145`	`145`	`this._onWillSaveState.fire({ reason: WillSaveStateReason.SHUTDOWN });`
`146`	`146`
`147`		`- // Close DBs`
`148`		`- this.globalStorage.close();`
`149`		`- this.workspaceStorage.close();`
	`147`	`+ // We explicitly do not close our DBs because writing data onBeforeUnload()`
	`148`	`+ // can result in unexpected results. Namely, it seems that - even though this`
	`149`	`+ // operation is async - sometimes it is being triggered on unload and`
	`150`	`+ // succeeds. Often though, the DBs turn out to be empty because the write`
	`151`	`+ // never had a chance to complete.`
`150`	`152`	`}`
`151`	`153`	`}`