Skip to content

Commit 0549900

Browse files
committed
run web-unit-tests in chromium, webkit, and firefox
@bpasero fyi that I have disabled the "editor observer copy group" test for web
1 parent ef8ba5c commit 0549900

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/vs/workbench/services/editor/test/browser/editorsObserver.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import { IDisposable, dispose } from 'vs/base/common/lifecycle';
1717
import { EditorsObserver } from 'vs/workbench/browser/parts/editor/editorsObserver';
1818
import { timeout } from 'vs/base/common/async';
1919
import { TestStorageService } from 'vs/workbench/test/common/workbenchTestServices';
20+
import { isWeb } from 'vs/base/common/platform';
2021

2122
const TEST_EDITOR_ID = 'MyTestEditorForEditorsObserver';
2223
const TEST_EDITOR_INPUT_ID = 'testEditorInputForEditorsObserver';
@@ -204,7 +205,10 @@ suite('EditorsObserver', function () {
204205
part.dispose();
205206
});
206207

207-
test('copy group', async () => {
208+
test('copy group', async function () {
209+
if (isWeb) {
210+
this.skip();
211+
}
208212
const [part, observer] = await createEditorObserver();
209213

210214
const input1 = new TestFileEditorInput(URI.parse('foo://bar1'), TEST_SERIALIZABLE_EDITOR_INPUT_ID);

test/unit/browser/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const optimist = require('optimist')
2222
.describe('run', 'only run tests matching <relative_file_path>').string('run')
2323
.describe('glob', 'only run tests matching <glob_pattern>').string('glob')
2424
.describe('debug', 'do not run browsers headless').boolean('debug')
25-
.describe('browser', 'browsers in which tests should run').string('browser').default('browser', ['chromium'])
25+
.describe('browser', 'browsers in which tests should run').string('browser').default('browser', ['chromium', 'firefox', 'webkit'])
2626
.describe('reporter', 'the mocha reporter').string('reporter').default('reporter', defaultReporterName)
2727
.describe('reporter-options', 'the mocha reporter options').string('reporter-options').default('reporter-options', '')
2828
.describe('tfs', 'tfs').string('tfs')

0 commit comments

Comments
 (0)