fix microsoft#37808

jrieken · jrieken · commit 04fc390148e6 · 2017-11-08T10:33:37.000+01:00
diff --git a/src/vs/editor/contrib/rename/browser/rename.ts b/src/vs/editor/contrib/rename/browser/rename.ts
@@ -6,7 +6,7 @@
 'use strict';
 
 import * as nls from 'vs/nls';
-import { isPromiseCanceledError, onUnexpectedExternalError, illegalArgument } from 'vs/base/common/errors';
+import { isPromiseCanceledError, illegalArgument } from 'vs/base/common/errors';
 import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
 import Severity from 'vs/base/common/severity';
 import { TPromise } from 'vs/base/common/winjs.base';
@@ -52,9 +52,6 @@ export function rename(model: IReadOnlyModel, position: Position, newName: strin
 						rejects.push(result.rejectReason);
 					}
 					return undefined;
-				}, err => {
-					onUnexpectedExternalError(err);
-					return TPromise.wrapError<WorkspaceEdit>(new Error('provider failed'));
 				});
 			}
 			return undefined;
@@ -154,7 +151,7 @@ class RenameController implements IEditorContribution {
 
 			const renameOperation = rename(this.editor.getModel(), this.editor.getPosition(), newName).then(result => {
 				if (result.rejectReason) {
-					this._messageService.show(Severity.Error, result.rejectReason);
+					this._messageService.show(Severity.Info, result.rejectReason);
 					return undefined;
 				}
 				edit.add(result.edits);
diff --git a/src/vs/workbench/api/node/extHostLanguageFeatures.ts b/src/vs/workbench/api/node/extHostLanguageFeatures.ts
@@ -460,8 +460,15 @@ class RenameAdapter {
 					edits: undefined,
 					rejectReason: err
 				};
+			} else if (err instanceof Error && typeof err.message === 'string') {
+				return <modes.WorkspaceEdit>{
+					edits: undefined,
+					rejectReason: err.message
+				};
+			} else {
+				// generic error
+				return TPromise.wrapError<modes.WorkspaceEdit>(err);
 			}
-			return TPromise.wrapError<modes.WorkspaceEdit>(err);
 		});
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -460,8 +460,15 @@ class RenameAdapter {`
`460`	`460`	`edits: undefined,`
`461`	`461`	`rejectReason: err`
`462`	`462`	`};`
	`463`	`+ } else if (err instanceof Error && typeof err.message === 'string') {`
	`464`	`+ return <modes.WorkspaceEdit>{`
	`465`	`+ edits: undefined,`
	`466`	`+ rejectReason: err.message`
	`467`	`+ };`
	`468`	`+ } else {`
	`469`	`+ // generic error`
	`470`	`+ return TPromise.wrapError<modes.WorkspaceEdit>(err);`
`463`	`471`	`}`
`464`		`- return TPromise.wrapError<modes.WorkspaceEdit>(err);`
`465`	`472`	`});`
`466`	`473`	`}`
`467`	`474`	`}`