microsoft#100346 merge single resource

sandy081 · sandy081 · commit 04aa49cbbea1 · 2020-07-13T12:03:04.000+02:00
diff --git a/src/vs/platform/userDataSync/common/userDataSync.ts b/src/vs/platform/userDataSync/common/userDataSync.ts
@@ -369,10 +369,10 @@ export interface ISyncTask {
 export interface IManualSyncTask {
 	readonly manifest: IUserDataManifest | null;
 	preview(): Promise<[SyncResource, ISyncResourcePreview][]>;
-	merge(): Promise<[SyncResource, ISyncResourcePreview][]>;
+	accept(uri: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]>;
+	merge(uri: URI): Promise<[SyncResource, ISyncResourcePreview][]>;
 	pull(): Promise<void>;
 	push(): Promise<void>;
-	accept(uri: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]>;
 	stop(): Promise<void>;
 }
 
diff --git a/src/vs/platform/userDataSync/common/userDataSyncIpc.ts b/src/vs/platform/userDataSync/common/userDataSyncIpc.ts
@@ -86,7 +86,7 @@ class ManualSyncTaskChannel implements IServerChannel {
 		switch (command) {
 			case 'preview': return this.manualSyncTask.preview();
 			case 'accept': return this.manualSyncTask.accept(URI.revive(args[0]), args[1]);
-			case 'merge': return this.manualSyncTask.merge();
+			case 'merge': return this.manualSyncTask.merge(URI.revive(args[0]));
 			case 'pull': return this.manualSyncTask.pull();
 			case 'push': return this.manualSyncTask.push();
 			case 'stop': return this.manualSyncTask.stop();
diff --git a/src/vs/platform/userDataSync/common/userDataSyncService.ts b/src/vs/platform/userDataSync/common/userDataSyncService.ts
@@ -490,22 +490,19 @@ class ManualSyncTask implements IManualSyncTask {
 		return this.previews;
 	}
 
-	async merge(): Promise<[SyncResource, ISyncResourcePreview][]> {
+	async merge(resource: URI): Promise<[SyncResource, ISyncResourcePreview][]> {
 		if (!this.previews) {
 			throw new Error('You need to create preview before applying');
 		}
-		const previews: [SyncResource, ISyncResourcePreview][] = [];
-		for (const [syncResource, preview] of this.previews) {
-			const synchroniser = this.synchronisers.find(s => s.resource === syncResource)!;
-			let newPreview: ISyncResourcePreview | null = null;
-			for (const resourcePreview of preview.resourcePreviews) {
-				newPreview = await synchroniser.merge(resourcePreview.previewResource, false, this.syncHeaders);
-			}
-			if (newPreview) {
-				previews.push(this.toSyncResourcePreview(syncResource, newPreview));
-			}
+		const index = this.previews.findIndex(([, preview]) => preview.resourcePreviews.some(({ localResource, previewResource, remoteResource }) =>
+			isEqual(resource, localResource) || isEqual(resource, previewResource) || isEqual(resource, remoteResource)));
+		if (index !== -1) {
+			const synchroniser = this.synchronisers.find(s => s.resource === this.previews![index][0])!;
+			/* force only if the resource is local or remote resource */
+			const force = this.previews![index][1].resourcePreviews.some(({ localResource, remoteResource }) => isEqual(resource, localResource) || isEqual(resource, remoteResource));
+			const preview = await synchroniser.merge(resource, force, this.syncHeaders);
+			preview ? this.previews.splice(index, 1, this.toSyncResourcePreview(synchroniser.resource, preview)) : this.previews.splice(index, 1);
 		}
-		this.previews = previews;
 		return this.previews;
 	}
 
diff --git a/src/vs/workbench/services/userDataSync/electron-browser/userDataSyncService.ts b/src/vs/workbench/services/userDataSync/electron-browser/userDataSyncService.ts
@@ -181,12 +181,12 @@ class ManualSyncTask implements IManualSyncTask {
 			]));
 	}
 
-	accept(uri: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]> {
-		return this.channel.call('accept', [uri, content]);
+	accept(resource: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]> {
+		return this.channel.call('accept', [resource, content]);
 	}
 
-	merge(): Promise<[SyncResource, ISyncResourcePreview][]> {
-		return this.channel.call('merge');
+	merge(resource: URI): Promise<[SyncResource, ISyncResourcePreview][]> {
+		return this.channel.call('merge', [resource]);
 	}
 
 	pull(): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -181,12 +181,12 @@ class ManualSyncTask implements IManualSyncTask {`
`181`	`181`	`]));`
`182`	`182`	`}`
`183`	`183`
`184`		`- accept(uri: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]> {`
`185`		`- return this.channel.call('accept', [uri, content]);`
	`184`	`+ accept(resource: URI, content: string): Promise<[SyncResource, ISyncResourcePreview][]> {`
	`185`	`+ return this.channel.call('accept', [resource, content]);`
`186`	`186`	`}`
`187`	`187`
`188`		`- merge(): Promise<[SyncResource, ISyncResourcePreview][]> {`
`189`		`- return this.channel.call('merge');`
	`188`	`+ merge(resource: URI): Promise<[SyncResource, ISyncResourcePreview][]> {`
	`189`	`+ return this.channel.call('merge', [resource]);`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`pull(): Promise<void> {`