don't cache provider results when request was cancelled, microsoft#74446

jrieken · jrieken · commit 034165ac674c · 2019-05-28T12:15:53.000+02:00
diff --git a/src/vs/workbench/api/common/extHostLanguageFeatures.ts b/src/vs/workbench/api/common/extHostLanguageFeatures.ts
@@ -644,6 +644,12 @@ class SuggestAdapter {
 				return undefined;
 			}
 
+			if (token.isCancellationRequested) {
+				// cancelled -> return without further ado, esp no caching
+				// of results as they will leak
+				return undefined;
+			}
+
 			let list = Array.isArray(value) ? new CompletionList(value) : value;
 			let pid: number | undefined;
 
@@ -832,6 +838,12 @@ class LinkProviderAdapter {
 				return undefined;
 			}
 
+			if (token.isCancellationRequested) {
+				// cancelled -> return without further ado, esp no caching
+				// of results as they will leak
+				return undefined;
+			}
+
 			if (typeof this._provider.resolveDocumentLink !== 'function') {
 				// no resolve -> no caching
 				return { links: links.map(typeConvert.DocumentLink.from) };
