fix microsoft#59274

jrieken · jrieken · commit 015deacd2583 · 2018-09-26T11:32:13.000+02:00
diff --git a/src/vs/editor/contrib/documentSymbols/outlineModel.ts b/src/vs/editor/contrib/documentSymbols/outlineModel.ts
@@ -150,13 +150,13 @@ export class OutlineGroup extends TreeElement {
 	}
 
 	getItemEnclosingPosition(position: IPosition): OutlineElement {
-		return this._getItemEnclosingPosition(position, this.children);
+		return position ? this._getItemEnclosingPosition(position, this.children) : undefined;
 	}
 
 	private _getItemEnclosingPosition(position: IPosition, children: { [id: string]: OutlineElement }): OutlineElement {
 		for (let key in children) {
 			let item = children[key];
-			if (!Range.containsPosition(item.symbol.range, position)) {
+			if (!item.symbol.range || !Range.containsPosition(item.symbol.range, position)) {
 				continue;
 			}
 			return this._getItemEnclosingPosition(position, item.children) || item;

Original file line number	Diff line number	Diff line change
`@@ -150,13 +150,13 @@ export class OutlineGroup extends TreeElement {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`getItemEnclosingPosition(position: IPosition): OutlineElement {`
`153`		`- return this._getItemEnclosingPosition(position, this.children);`
	`153`	`+ return position ? this._getItemEnclosingPosition(position, this.children) : undefined;`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`private _getItemEnclosingPosition(position: IPosition, children: { [id: string]: OutlineElement }): OutlineElement {`
`157`	`157`	`for (let key in children) {`
`158`	`158`	`let item = children[key];`
`159`		`- if (!Range.containsPosition(item.symbol.range, position)) {`
	`159`	`+ if (!item.symbol.range \|\| !Range.containsPosition(item.symbol.range, position)) {`
`160`	`160`	`continue;`
`161`	`161`	`}`
`162`	`162`	`return this._getItemEnclosingPosition(position, item.children) \|\| item;`