Fix fall error logging for setLevel

mjbvz · mjbvz · commit 0046a33fbfb2 · 2019-03-07T14:04:48.000-08:00
Switch case should not fall through here since we do handle the change properly Fixes microsoft#69990
diff --git a/src/vs/platform/log/node/logIpc.ts b/src/vs/platform/log/node/logIpc.ts
@@ -25,7 +25,7 @@ export class LogLevelSetterChannel implements IServerChannel {
 
 	call(_, command: string, arg?: any): Promise<any> {
 		switch (command) {
-			case 'setLevel': this.service.setLevel(arg);
+			case 'setLevel': this.service.setLevel(arg); return Promise.resolve();
 		}
 
 		throw new Error(`Call not found: ${command}`);

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class LogLevelSetterChannel implements IServerChannel {`
`25`	`25`
`26`	`26`	`call(_, command: string, arg?: any): Promise<any> {`
`27`	`27`	`switch (command) {`
`28`		`- case 'setLevel': this.service.setLevel(arg);`
	`28`	`+ case 'setLevel': this.service.setLevel(arg); return Promise.resolve();`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	throw new Error(`Call not found: ${command}`);