https-github-com-simontrinh0911 · simontrinh0911 · Sep 1, 2022 · Sep 1, 2022 · Sep 1, 2022 · Sep 1, 2022
diff --git a/.github/actions-scripts/create-translation-batch-pr.js b/.github/actions-scripts/create-translation-batch-pr.js
@@ -107,14 +107,14 @@ async function findOrCreatePullRequest(config) {
  * @param {object} config Configuration options for labeling the PR
  * @returns {Promise<undefined>}
  */
-async function labelPullRequest(config) {
-  await octokit.rest.issues.update({
-    owner: config.owner,
-    repo: config.repo,
-    issue_number: config.issue_number,
-    labels: config.labels,
-  })
-}
+// async function labelPullRequest(config) {
+//   await octokit.rest.issues.update({
+//     owner: config.owner,
+//     repo: config.repo,
+//     issue_number: config.issue_number,
+//     labels: config.labels,
+//   })
+// }
 
 async function main() {
   const options = {
@@ -135,8 +135,8 @@ async function main() {
 
   // metadata parameters aren't currently available in `github.rest.pulls.create`,
   // but they are in `github.rest.issues.update`.
-  await labelPullRequest(options)
-  console.log(`Updated ${pr} with these labels: ${options.labels.join(', ')}`)
+  // await labelPullRequest(options)
+  // console.log(`Updated ${pr} with these labels: ${options.labels.join(', ')}`)
 }
 
 main()
diff --git a/.github/actions-scripts/enterprise-server-issue-templates/release-issue.md b/.github/actions-scripts/enterprise-server-issue-templates/release-issue.md
@@ -18,7 +18,7 @@ If you aren't comfortable going through the steps alone, sync up with a docs eng
     ```
     script/update-enterprise-dates.js
     ```
-- [ ] Create REST files based on previous version. Copy the latest GHES version of the dereferenced file from `lib/rest/static/dereferenced` to a new file in the same directory for the new GHES release. Ex, `cp lib/rest/static/dereferenced/ghes-3.4.deref.json lib/rest/static/dereferenced/ghes-3.5.deref.json`. Then run `script/rest/updated-files.js --decorate-only` and check in the resulting files.
+- [ ] Create REST files based on previous version. Copy the latest GHES version of the dereferenced file from `lib/rest/static/dereferenced` to a new file in the same directory for the new GHES release. Ex, `cp lib/rest/static/dereferenced/ghes-3.4.deref.json lib/rest/static/dereferenced/ghes-3.5.deref.json`. Then run `script/rest/update-files.js --decorate-only` and check in the resulting files.
 
 - [ ] Create GraphQL files based on previous version:
 

diff --git a/.github/actions-scripts/msft-create-translation-batch-pr.js b/.github/actions-scripts/msft-create-translation-batch-pr.js
@@ -107,14 +107,14 @@ async function findOrCreatePullRequest(config) {
  * @param {object} config Configuration options for labeling the PR
  * @returns {Promise<undefined>}
  */
-// async function labelPullRequest(config) {
-//   await octokit.rest.issues.update({
-//     owner: config.owner,
-//     repo: config.repo,
-//     issue_number: config.issue_number,
-//     labels: config.labels,
-//   })
-// }
+async function labelPullRequest(config) {
+  await octokit.rest.issues.update({
+    owner: config.owner,
+    repo: config.repo,
+    issue_number: config.issue_number,
+    labels: config.labels,
+  })
+}
 
 async function main() {
   const options = {
@@ -135,8 +135,8 @@ async function main() {
 
   // metadata parameters aren't currently available in `github.rest.pulls.create`,
   // but they are in `github.rest.issues.update`.
-  // await labelPullRequest(options)
-  // console.log(`Updated ${pr} with these labels: ${options.labels.join(', ')}`)
+  await labelPullRequest(options)
+  console.log(`Updated ${pr} with these labels: ${options.labels.join(', ')}`)
 }
 
 main()
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -7,6 +7,7 @@ updates:
       day: tuesday
     open-pull-requests-limit: 20 # default is 5
     ignore:
+      - dependency-name: '@elastic/elasticsearch'
       - dependency-name: '*'
         update-types:
           ['version-update:semver-patch', 'version-update:semver-minor']

diff --git a/.github/workflows/copy-api-issue-to-internal.yml b/.github/workflows/copy-api-issue-to-internal.yml
@@ -52,13 +52,6 @@ jobs:
           ISSUE_TITLE: ${{ github.event.issue.title }}
           ISSUE_BODY: ${{ github.event.issue.body }}
 
-      - name: Comment on the new issue
-        run: gh issue comment $NEW_ISSUE --body "This issue was originally opened in the open source repo as $OLD_ISSUE"
-        env:
-          GITHUB_TOKEN: ${{secrets.DOCUBOT_READORG_REPO_WORKFLOW_SCOPES}}
-          NEW_ISSUE: ${{ env.NEW_ISSUE }}
-          OLD_ISSUE: ${{ github.event.issue.html_url }}
-
       - name: Comment on the old issue
         run: gh issue comment $OLD_ISSUE --body "Thank you for opening this issue! Updates to the REST/GraphQL API description must be made internally. I have copied your issue to an internal issue, so I will close this issue."
         env:
@@ -70,3 +63,10 @@ jobs:
         env:
           GITHUB_TOKEN: ${{secrets.DOCUBOT_READORG_REPO_WORKFLOW_SCOPES}}
           OLD_ISSUE: ${{ github.event.issue.html_url }}
+
+      - name: Comment on the new issue
+        run: gh issue comment $NEW_ISSUE --body "This issue was originally opened in the open source repo as $OLD_ISSUE"
+        env:
+          GITHUB_TOKEN: ${{secrets.DOCUBOT_READORG_REPO_WORKFLOW_SCOPES}}
+          NEW_ISSUE: ${{ env.NEW_ISSUE }}
+          OLD_ISSUE: ${{ github.event.issue.html_url }}
diff --git a/.github/workflows/create-translation-batch-pr.yml b/.github/workflows/create-translation-batch-pr.yml
@@ -10,8 +10,8 @@ name: Create translation Batch Pull Request
 
 on:
   workflow_dispatch:
-  schedule:
-    - cron: '02 17 * * *' # Once a day at 17:02 UTC / 9:02 PST
+  # schedule:
+  #   - cron: '02 17 * * *' # Once a day at 17:02 UTC / 9:02 PST
 
 permissions:
   contents: write
@@ -172,11 +172,11 @@ jobs:
       - name: Push filtered translations
         run: git push origin ${{ steps.set-branch.outputs.BRANCH_NAME }}
 
-      - name: Close existing stale batches
-        uses: lee-dohm/close-matching-issues@e9e43aad2fa6f06a058cedfd8fb975fd93b56d8f
-        with:
-          token: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-          query: 'type:pr label:translation-batch-${{ matrix.language }}'
+      # - name: Close existing stale batches
+      #   uses: lee-dohm/close-matching-issues@e9e43aad2fa6f06a058cedfd8fb975fd93b56d8f
+      #   with:
+      #     token: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+      #     query: 'type:pr label:translation-batch-${{ matrix.language }}'
 
       - name: Create translation batch pull request
         env:
@@ -188,35 +188,35 @@ jobs:
           BODY_FILE: '/tmp/pr-body.txt'
         run: .github/actions-scripts/create-translation-batch-pr.js
 
-      - name: Approve PR
-        if: github.ref_name == 'main'
-        env:
-          GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-        run: gh pr review --approve || echo "Nothing to approve"
-
-      - name: Set auto-merge
-        if: github.ref_name == 'main'
-        env:
-          GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-        run: gh pr merge ${{ steps.set-branch.outputs.BRANCH_NAME }} --auto --squash || echo "Nothing to merge"
-
-      # When the maximum execution time is reached for this job, Actions cancels the workflow run.
-      # This emits a notification for the first responder to triage.
-      - name: Send Slack notification if workflow is cancelled
-        uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
-        if: cancelled()
-        with:
-          channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
-          color: failure
-          text: 'The new translation batch for ${{ matrix.language }} was cancelled.'
-
-      # Emit a notification for the first responder to triage if the workflow failed.
-      - name: Send Slack notification if workflow failed
-        uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
-        if: failure()
-        with:
-          channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
-          color: failure
-          text: 'The new translation batch for ${{ matrix.language }} failed.'
+      # - name: Approve PR
+      #   if: github.ref_name == 'main'
+      #   env:
+      #     GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+      #   run: gh pr review --approve || echo "Nothing to approve"
+
+      # - name: Set auto-merge
+      #   if: github.ref_name == 'main'
+      #   env:
+      #     GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+      #   run: gh pr merge ${{ steps.set-branch.outputs.BRANCH_NAME }} --auto --squash || echo "Nothing to merge"
+
+      # # When the maximum execution time is reached for this job, Actions cancels the workflow run.
+      # # This emits a notification for the first responder to triage.
+      # - name: Send Slack notification if workflow is cancelled
+      #   uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
+      #   if: cancelled()
+      #   with:
+      #     channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+      #     bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
+      #     color: failure
+      #     text: 'The new translation batch for ${{ matrix.language }} was cancelled.'
+
+      # # Emit a notification for the first responder to triage if the workflow failed.
+      # - name: Send Slack notification if workflow failed
+      #   uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
+      #   if: failure()
+      #   with:
+      #     channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+      #     bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
+      #     color: failure
+      #     text: 'The new translation batch for ${{ matrix.language }} failed.'
diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml
@@ -53,6 +53,14 @@ jobs:
           # Don't care about CDN caching image URLs
           DISABLE_REWRITE_ASSET_URLS: true
         run: |
+
+          # Note as of Aug 2022, we *don't* check external links
+          # on the pages you touched in the PR. We could enable that
+          # but it has the added risk of false positives blocking CI.
+          # We are using this script for the daily/nightly checker that
+          # checks external links too. Once we're confident it really works
+          # well, we can consider enabling it here on every content PR too.
+
           ./script/rendered-content-link-checker.js \
             --language en \
             --max 100 \

diff --git a/.github/workflows/msft-create-translation-batch-pr.yml b/.github/workflows/msft-create-translation-batch-pr.yml
@@ -10,9 +10,8 @@ name: Create translation Batch Pull Request (Microsoft)
 
 on:
   workflow_dispatch:
-  # TODO: bring schedule back in
-  # schedule:
-  #   - cron: '02 17 * * *' # Once a day at 17:02 UTC / 9:02 PST
+  schedule:
+    - cron: '02 17 * * *' # Once a day at 17:02 UTC / 9:02 PST
 
 permissions:
   contents: write
@@ -145,54 +144,51 @@ jobs:
       - name: Push filtered translations
         run: git push origin ${{ steps.set-branch.outputs.BRANCH_NAME }}
 
-      # TODO: bring this step back
-      # - name: Close existing stale batches
-      #   uses: lee-dohm/close-matching-issues@e9e43aad2fa6f06a058cedfd8fb975fd93b56d8f
-      #   with:
-      #     token: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-      #     query: 'type:pr label:translation-batch-${{ matrix.language }}'
+      - name: Close existing stale batches
+        uses: lee-dohm/close-matching-issues@e9e43aad2fa6f06a058cedfd8fb975fd93b56d8f
+        with:
+          token: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+          query: 'type:pr label:translation-batch-${{ matrix.language }}'
 
-      # TODO: bring labels back into the PR script
       - name: Create translation batch pull request
         env:
           GITHUB_TOKEN: ${{ secrets.DOCUBOT_REPO_PAT }}
-          TITLE: '[DO NOT MERGE] Msft: New translation batch for ${{ matrix.language }}'
+          TITLE: 'New translation batch for ${{ matrix.language }}'
           BASE: 'main'
           HEAD: ${{ steps.set-branch.outputs.BRANCH_NAME }}
           LANGUAGE: ${{ matrix.language }}
           BODY_FILE: '/tmp/pr-body.txt'
         run: .github/actions-scripts/msft-create-translation-batch-pr.js
 
-      # TODO: bring back these steps
-      # - name: Approve PR
-      #   if: github.ref_name == 'main'
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-      #   run: gh pr review --approve || echo "Nothing to approve"
-
-      # - name: Set auto-merge
-      #   if: github.ref_name == 'main'
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
-      #   run: gh pr merge ${{ steps.set-branch.outputs.BRANCH_NAME }} --auto --squash || echo "Nothing to merge"
-
-      # # When the maximum execution time is reached for this job, Actions cancels the workflow run.
-      # # This emits a notification for the first responder to triage.
-      # - name: Send Slack notification if workflow is cancelled
-      #   uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
-      #   if: cancelled()
-      #   with:
-      #     channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-      #     bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
-      #     color: failure
-      #     text: 'The new translation batch for ${{ matrix.language }} was cancelled.'
-
-      # # Emit a notification for the first responder to triage if the workflow failed.
-      # - name: Send Slack notification if workflow failed
-      #   uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
-      #   if: failure()
-      #   with:
-      #     channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-      #     bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
-      #     color: failure
-      #     text: 'The new translation batch for ${{ matrix.language }} failed.'
+      - name: Approve PR
+        if: github.ref_name == 'main'
+        env:
+          GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+        run: gh pr review --approve || echo "Nothing to approve"
+
+      - name: Set auto-merge
+        if: github.ref_name == 'main'
+        env:
+          GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
+        run: gh pr merge ${{ steps.set-branch.outputs.BRANCH_NAME }} --auto --squash || echo "Nothing to merge"
+
+      # When the maximum execution time is reached for this job, Actions cancels the workflow run.
+      # This emits a notification for the first responder to triage.
+      - name: Send Slack notification if workflow is cancelled
+        uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
+        if: cancelled()
+        with:
+          channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+          bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}🎉
+          color: failure
+          text: 'The new translation batch for ${{ matrix.language }} was cancelled.'
+
+      # Emit a notification for the first responder to triage if the workflow failed.
+      - name: Send Slack notification if workflow failed
+        uses: someimportantcompany/github-actions-slack-message@f8d28715e7b8a4717047d23f48c39827cacad340
+        if: failure()
+        with:
+          channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+          bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
+          color: failure
+          text: 'The new translation batch for ${{ matrix.language }} failed.'
diff --git a/.github/workflows/site-policy-reminder.yml b/.github/workflows/site-policy-reminder.yml
@@ -9,6 +9,7 @@ on:
     types: [labeled]
 
 permissions:
+  pull-requests: write
   contents: none
 
 jobs:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -23,6 +23,9 @@ env:
   # Setting this will activate the jest tests that depend on actually
   # sending real search queries to Elasticsearch
   ELASTICSEARCH_URL: http://localhost:9200/
+  # Hopefully the name is clear enough. By enabling this, we're testing
+  # the future code.
+  ENABLE_SEARCH_RESULTS_PAGE: true
 
 jobs:
   test:
@@ -52,7 +55,7 @@ jobs:
         if: ${{ matrix.test-group == 'content' }}
         uses: getong/elasticsearch-action@95b501ab0c83dee0aac7c39b7cea3723bef14954
         with:
-          elasticsearch version: '7.17.5'
+          elasticsearch version: '7.11.1'
           host port: 9200
           container port: 9200
           host node port: 9300

diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 .DS_Store
 .env
 .vscode/settings.json
+.idea/
 /node_modules/
 npm-debug.log
 coverage/

diff --git a/assets/images/help/business-accounts/project-visibility-change-drop-down.png b/assets/images/help/business-accounts/project-visibility-change-drop-down.png
diff --git a/assets/images/help/classroom/classroom-settings-click-google-classroom.png b/assets/images/help/classroom/classroom-settings-click-google-classroom.png
diff --git a/assets/images/help/codespaces/codespaces-badge-on-readme.png b/assets/images/help/codespaces/codespaces-badge-on-readme.png
diff --git a/assets/images/help/codespaces/configure-and-create-option.png b/assets/images/help/codespaces/configure-and-create-option.png
diff --git a/assets/images/help/codespaces/jupyter-notebook-step3.png b/assets/images/help/codespaces/jupyter-notebook-step3.png
diff --git a/assets/images/help/codespaces/jupyter-python-kernel-dropdown.png b/assets/images/help/codespaces/jupyter-python-kernel-dropdown.png
diff --git a/assets/images/help/codespaces/jupyter-python-kernel-link.png b/assets/images/help/codespaces/jupyter-python-kernel-link.png
diff --git a/assets/images/help/codespaces/jupyter-run-all.png b/assets/images/help/codespaces/jupyter-run-all.png
diff --git a/assets/images/help/codespaces/open-codespace-in-jupyter.png b/assets/images/help/codespaces/open-codespace-in-jupyter.png
diff --git a/assets/images/help/enterprises/audit-stream-choice-datadog.png b/assets/images/help/enterprises/audit-stream-choice-datadog.png
diff --git a/assets/images/help/enterprises/audit-stream-datadog-site.png b/assets/images/help/enterprises/audit-stream-datadog-site.png
diff --git a/assets/images/help/enterprises/audit-stream-datadog-token.png b/assets/images/help/enterprises/audit-stream-datadog-token.png
diff --git a/assets/images/help/issues/development-menu-apply.png b/assets/images/help/issues/development-menu-apply.png
diff --git a/assets/images/help/issues/development-menu-select-pr-or-branch.png b/assets/images/help/issues/development-menu-select-pr-or-branch.png
diff --git a/assets/images/help/issues/development-menu-select-repository.png b/assets/images/help/issues/development-menu-select-repository.png
diff --git a/assets/images/help/issues/development-menu.png b/assets/images/help/issues/development-menu.png
diff --git a/assets/images/help/notifications/gmail-buttons.png b/assets/images/help/notifications/gmail-buttons.png
diff --git a/assets/images/help/settings/cookie-settings-accept-or-reject.png b/assets/images/help/settings/cookie-settings-accept-or-reject.png
diff --git a/assets/images/help/settings/cookie-settings-manage.png b/assets/images/help/settings/cookie-settings-manage.png
diff --git a/assets/images/help/settings/cookie-settings-save.png b/assets/images/help/settings/cookie-settings-save.png
diff --git a/assets/images/help/settings/ssh-sso-authorize.png b/assets/images/help/settings/ssh-sso-authorize.png
diff --git a/assets/images/help/settings/ssh-sso-button.png b/assets/images/help/settings/ssh-sso-button.png
diff --git a/assets/images/hosted-runner-mgmt.png b/assets/images/hosted-runner-mgmt.png
diff --git a/assets/images/hosted-runner.png b/assets/images/hosted-runner.png
diff --git a/components/context/PlaygroundContext.tsx b/components/context/PlaygroundContext.tsx
@@ -59,8 +59,9 @@ export const PlaygroundContextProvider = (props: { children: React.ReactNode })
   const router = useRouter()
   const [activeSectionIndex, setActiveSectionIndex] = useState(0)
   const [scrollToSection, setScrollToSection] = useState<number>()
-  const path = router.asPath.split('?')[0].split('#')[0]
-
+  const path = router.asPath.includes('@latest')
+    ? router.asPath.split('?')[0].split('#')[0].split('@latest')[1]
+    : router.asPath.split('?')[0].split('#')[0]
   const relevantArticles = articles.filter(({ slug }) => slug === path)
 
   const { langId } = router.query