Fix bug:

Michael W. Hudson · Michael W. Hudson · commit b2308bb9be49 · 2005-10-21T11:45:01.000Z
[ 1327110 ] wrong TypeError traceback in generator expressions

by removing the code that can stomp on the users' TypeError raised by the
iterable argument to ''.join() -- PySequence_Fast (now?) gives a perfectly
reasonable message itself.  Also, a couple of tests.
diff --git a/Lib/test/string_tests.py b/Lib/test/string_tests.py
@@ -657,6 +657,15 @@ def test_join(self):
         self.checkraises(TypeError, ' ', 'join')
         self.checkraises(TypeError, ' ', 'join', 7)
         self.checkraises(TypeError, ' ', 'join', Sequence([7, 'hello', 123L]))
+        try:
+            def f():
+                yield 4 + ""
+            self.fixtype(' ').join(f())
+        except TypeError, e:
+            if '+' not in str(e):
+                self.fail('join() ate exception message')
+        else:
+            self.fail('exception not raised')
 
     def test_formatting(self):
         self.checkequal('+hello+', '+%s+', '__mod__', 'hello')
diff --git a/Lib/test/test_string.py b/Lib/test/test_string.py
@@ -51,6 +51,17 @@ def test_join(self):
 
         self.checkraises(TypeError, string_tests.BadSeq1(), 'join', ' ')
         self.checkequal('a b c', string_tests.BadSeq2(), 'join', ' ')
+        try:
+            def f():
+                yield 4 + ""
+            self.fixtype(' ').join(f())
+        except TypeError, e:
+            if '+' not in str(e):
+                self.fail('join() ate exception message')
+        else:
+            self.fail('exception not raised')
+
+
 
 
 class ModuleTest(unittest.TestCase):
diff --git a/Objects/stringobject.c b/Objects/stringobject.c
@@ -1620,10 +1620,6 @@ string_join(PyStringObject *self, PyObject *orig)
 
 	seq = PySequence_Fast(orig, "");
 	if (seq == NULL) {
-		if (PyErr_ExceptionMatches(PyExc_TypeError))
-			PyErr_Format(PyExc_TypeError,
-				     "sequence expected, %.80s found",
-				     orig->ob_type->tp_name);
 		return NULL;
 	}
 
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -4148,10 +4148,6 @@ PyUnicode_Join(PyObject *separator, PyObject *seq)
 
     fseq = PySequence_Fast(seq, "");
     if (fseq == NULL) {
-	if (PyErr_ExceptionMatches(PyExc_TypeError))
-	    PyErr_Format(PyExc_TypeError,
-			 "sequence expected, %.80s found",
-			 seq->ob_type->tp_name);
     	return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1620,10 +1620,6 @@ string_join(PyStringObject self, PyObject orig)`
`1620`	`1620`
`1621`	`1621`	`seq = PySequence_Fast(orig, "");`
`1622`	`1622`	`if (seq == NULL) {`
`1623`		`- if (PyErr_ExceptionMatches(PyExc_TypeError))`
`1624`		`- PyErr_Format(PyExc_TypeError,`
`1625`		`- "sequence expected, %.80s found",`
`1626`		`- orig->ob_type->tp_name);`
`1627`	`1623`	`return NULL;`
`1628`	`1624`	`}`
`1629`	`1625`
Original file line number	Diff line number	Diff line change
`@@ -4148,10 +4148,6 @@ PyUnicode_Join(PyObject separator, PyObject seq)`
`4148`	`4148`
`4149`	`4149`	`fseq = PySequence_Fast(seq, "");`
`4150`	`4150`	`if (fseq == NULL) {`
`4151`		`- if (PyErr_ExceptionMatches(PyExc_TypeError))`
`4152`		`- PyErr_Format(PyExc_TypeError,`
`4153`		`- "sequence expected, %.80s found",`
`4154`		`- seq->ob_type->tp_name);`
`4155`	`4151`	`return NULL;`
`4156`	`4152`	`}`
`4157`	`4153`