Issue python#27533: Release GIL in nt._isdir

zooba · zooba · commit b22a67737ea2 · 2016-07-17T20:49:38.000-07:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -28,6 +28,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #27533: Release GIL in nt._isdir
+
 - Issue #17711: Fixed unpickling by the persistent ID with protocol 0.
   Original patch by Alexandre Vassalotti.
 
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -3878,10 +3878,12 @@ os__isdir_impl(PyObject *module, path_t *path)
 {
     DWORD attributes;
 
+    Py_BEGIN_ALLOW_THREADS
     if (!path->narrow)
         attributes = GetFileAttributesW(path->wide);
     else
         attributes = GetFileAttributesA(path->narrow);
+    Py_END_ALLOW_THREADS
 
     if (attributes == INVALID_FILE_ATTRIBUTES)
         Py_RETURN_FALSE;
