bpo-46927: Include the type's name in the error message for subscripting non-generic types (pythonGH-31694)

serhiy-storchaka · web-flow · commit ab9301a28fa4 · 2022-03-05T15:59:24.000+02:00
diff --git a/Lib/test/test_exception_group.py b/Lib/test/test_exception_group.py
@@ -11,7 +11,7 @@ def test_exception_group_types(self):
         self.assertTrue(issubclass(BaseExceptionGroup, BaseException))
 
     def test_exception_is_not_generic_type(self):
-        with self.assertRaises(TypeError):
+        with self.assertRaisesRegex(TypeError, 'Exception'):
             Exception[OSError]
 
     def test_exception_group_is_generic_type(self):
diff --git a/Lib/test/test_genericalias.py b/Lib/test/test_genericalias.py
@@ -109,7 +109,7 @@ def test_unsubscriptable(self):
         for t in int, str, float, Sized, Hashable:
             tname = t.__name__
             with self.subTest(f"Testing {tname}"):
-                with self.assertRaises(TypeError):
+                with self.assertRaisesRegex(TypeError, tname):
                     t[int]
 
     def test_instantiate(self):
@@ -275,7 +275,7 @@ def test_type_generic(self):
     def test_type_subclass_generic(self):
         class MyType(type):
             pass
-        with self.assertRaises(TypeError):
+        with self.assertRaisesRegex(TypeError, 'MyType'):
             MyType[int]
 
     def test_pickle(self):
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-03-05-12-23-58.bpo-46927.URbHBi.rst b/Misc/NEWS.d/next/Core and Builtins/2022-03-05-12-23-58.bpo-46927.URbHBi.rst
@@ -0,0 +1,2 @@
+Include the type's name in the error message for subscripting non-generic
+types.
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -190,6 +190,9 @@ PyObject_GetItem(PyObject *o, PyObject *key)
             Py_DECREF(meth);
             return result;
         }
+        PyErr_Format(PyExc_TypeError, "type '%.200s' is not subscriptable",
+                     ((PyTypeObject *)o)->tp_name);
+        return NULL;
     }
 
     return type_error("'%.200s' object is not subscriptable", o);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Include the type's name in the error message for subscripting non-generic`
	`2`	`+types.`
Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,9 @@ PyObject_GetItem(PyObject o, PyObject key)`
`190`	`190`	`Py_DECREF(meth);`
`191`	`191`	`return result;`
`192`	`192`	`}`
	`193`	`+ PyErr_Format(PyExc_TypeError, "type '%.200s' is not subscriptable",`
	`194`	`+ ((PyTypeObject *)o)->tp_name);`
	`195`	`+ return NULL;`
`193`	`196`	`}`
`194`	`197`
`195`	`198`	`return type_error("'%.200s' object is not subscriptable", o);`