Change fnmatch.py to use separate caches for str and bytes keys.

gvanrossum · gvanrossum · commit 3f2291f8025c · 2008-10-03T16:38:30.000Z
This is necessary to pass the tests with -bb.
diff --git a/Lib/fnmatch.py b/Lib/fnmatch.py
@@ -14,7 +14,8 @@
 
 __all__ = ["filter", "fnmatch","fnmatchcase","translate"]
 
-_cache = {}
+_cache = {}  # Maps text patterns to compiled regexen.
+_cacheb = {}  # Ditto for bytes patterns.
 
 def fnmatch(name, pat):
     """Test whether FILENAME matches PATTERN.
@@ -38,15 +39,16 @@ def fnmatch(name, pat):
     return fnmatchcase(name, pat)
 
 def _compile_pattern(pat):
-    regex = _cache.get(pat)
+    cache = _cacheb if isinstance(pat, bytes) else _cache
+    regex = cache.get(pat)
     if regex is None:
         if isinstance(pat, bytes):
             pat_str = str(pat, 'ISO-8859-1')
             res_str = translate(pat_str)
             res = bytes(res_str, 'ISO-8859-1')
         else:
             res = translate(pat)
-        _cache[pat] = regex = re.compile(res)
+        cache[pat] = regex = re.compile(res)
     return regex.match
 
 def filter(names, pat):
