Issue python#15068: Avoid creating a reference loop in fileinput.

serhiy-storchaka · serhiy-storchaka · commit 0554d83f0ff7 · 2016-03-08T23:35:35.000+02:00
diff --git a/Lib/fileinput.py b/Lib/fileinput.py
@@ -207,7 +207,6 @@ def __init__(self, files=None, inplace=False, backup="", bufsize=0,
         self._startlineno = 0
         self._filelineno = 0
         self._file = None
-        self._readline = self._start_readline
         self._isstdin = False
         self._backupfilename = None
         # restrict mode argument to reading modes
@@ -245,15 +244,15 @@ def __iter__(self):
         return self
 
     def __next__(self):
-        line = self._readline()
-        if line:
-            self._filelineno += 1
-            return line
-        if not self._file:
-            raise StopIteration
-        self.nextfile()
-        # Recursive call
-        return self.__next__()
+        while True:
+            line = self._readline()
+            if line:
+                self._filelineno += 1
+                return line
+            if not self._file:
+                raise StopIteration
+            self.nextfile()
+            # repeat with next file
 
     def __getitem__(self, i):
         if i != self.lineno():
@@ -277,7 +276,10 @@ def nextfile(self):
         finally:
             file = self._file
             self._file = None
-            self._readline = self._start_readline
+            try:
+                del self._readline  # restore FileInput._readline
+            except AttributeError:
+                pass
             try:
                 if file and not self._isstdin:
                     file.close()
@@ -301,7 +303,7 @@ def readline(self):
             self.nextfile()
             # repeat with next file
 
-    def _start_readline(self):
+    def _readline(self):
         if not self._files:
             if 'b' in self._mode:
                 return b''
@@ -356,7 +358,7 @@ def _start_readline(self):
                     self._file = self._openhook(self._filename, self._mode)
                 else:
                     self._file = open(self._filename, self._mode)
-        self._readline = self._file.readline
+        self._readline = self._file.readline  # hide FileInput._readline
         return self._readline()
 
     def filename(self):
