http: destroy socket on error

bnoordhuis · bnoordhuis · commit eb09b0644b3c · 2011-08-11T23:39:38.000+02:00
Needs further investigation, the test passed without `--use-uv`.

Fixes failing test:
  test/simple/test-http-dns-fail.js
diff --git a/lib/http2.js b/lib/http2.js
@@ -1088,6 +1088,7 @@ ClientRequest.prototype.onSocket = function(socket) {
     // and we need to make sure we don't double-fire the error event.
     req._hadError = true;
     parser.finish();
+    socket.destroy();
   }
   socket.on('error', errorListener);
 

Original file line number	Diff line number	Diff line change
`@@ -1088,6 +1088,7 @@ ClientRequest.prototype.onSocket = function(socket) {`
`1088`	`1088`	`// and we need to make sure we don't double-fire the error event.`
`1089`	`1089`	`req._hadError = true;`
`1090`	`1090`	`parser.finish();`
	`1091`	`+ socket.destroy();`
`1091`	`1092`	`}`
`1092`	`1093`	`socket.on('error', errorListener);`
`1093`	`1094`