resolve: fix possible memleak

yuwata · yuwata · commit fe8c5ce615ee · 2022-02-08T17:38:42.000+09:00
Fortunately, unlike the issue fixed in the previous commit, the memleak
should be superficial and not become apparent, as the queries handled
here are managed by the stub stream, and will be freed when the stream
is closed.

Just for safety, and slightly reducing the runtime memory usage by the
stub stream.
diff --git a/src/resolve/resolved-dns-stub.c b/src/resolve/resolved-dns-stub.c
@@ -791,8 +791,10 @@ static void dns_stub_query_complete(DnsQuery *q) {
                                  * packet doesn't answer our question. In that case let's restart the query,
                                  * now with the redirected question. We'll */
                                 r = dns_query_go(q);
-                                if (r < 0)
+                                if (r < 0) {
                                         log_debug_errno(r, "Failed to restart query: %m");
+                                        dns_query_free(q);
+                                }
 
                                 return;
                         }
