update-done: quit earlier on failure

yuwata · yuwata · commit fd1bff7db5da · 2018-11-23T06:22:30.000+09:00
diff --git a/src/update-done/update-done.c b/src/update-done/update-done.c
@@ -47,12 +47,11 @@ int main(int argc, char *argv[]) {
         r = mac_selinux_init();
         if (r < 0) {
                 log_error_errno(r, "SELinux setup failed: %m");
-                goto finish;
+                return EXIT_FAILURE;
         }
 
         r = apply_timestamp("/etc/.updated", &st.st_mtim);
         q = apply_timestamp("/var/.updated", &st.st_mtim);
 
-finish:
         return r < 0 || q < 0 ? EXIT_FAILURE : EXIT_SUCCESS;
 }

Original file line number	Diff line number	Diff line change
`@@ -47,12 +47,11 @@ int main(int argc, char *argv[]) {`
`47`	`47`	`r = mac_selinux_init();`
`48`	`48`	`if (r < 0) {`
`49`	`49`	`log_error_errno(r, "SELinux setup failed: %m");`
`50`		`- goto finish;`
	`50`	`+ return EXIT_FAILURE;`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`r = apply_timestamp("/etc/.updated", &st.st_mtim);`
`54`	`54`	`q = apply_timestamp("/var/.updated", &st.st_mtim);`
`55`	`55`
`56`		`-finish:`
`57`	`56`	`return r < 0 \|\| q < 0 ? EXIT_FAILURE : EXIT_SUCCESS;`
`58`	`57`	`}`