util: use alloca0() intead of alloca() + memzero()

poettering · poettering · commit fb818b2ea194 · 2014-01-31T17:48:36.000+01:00
diff --git a/src/python-systemd/_journal.c b/src/python-systemd/_journal.c
@@ -41,8 +41,7 @@ static PyObject *journal_sendv(PyObject *self, PyObject *args) {
 
         /* Allocate an array for the argument strings */
         argc = PyTuple_Size(args);
-        encoded = alloca(argc * sizeof(PyObject*));
-        memzero(encoded, argc * sizeof(PyObject*));
+        encoded = alloca0(argc * sizeof(PyObject*));
 
         /* Allocate sufficient iovector space for the arguments. */
         iov = alloca(argc * sizeof(struct iovec));
diff --git a/src/readahead/readahead-collect.c b/src/readahead/readahead-collect.c
@@ -129,8 +129,7 @@ static int pack_file(FILE *pack, const char *fn, bool on_btrfs) {
         }
 
         pages = l / page_size();
-        vec = alloca(pages);
-        memzero(vec, pages);
+        vec = alloca0(pages);
         if (mincore(start, l, vec) < 0) {
                 log_warning("mincore(%s) failed: %m", fn);
                 r = -errno;

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,7 @@ static int pack_file(FILE pack, const char fn, bool on_btrfs) {`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`pages = l / page_size();`
`132`		`- vec = alloca(pages);`
`133`		`- memzero(vec, pages);`
	`132`	`+ vec = alloca0(pages);`
`134`	`133`	`if (mincore(start, l, vec) < 0) {`
`135`	`134`	`log_warning("mincore(%s) failed: %m", fn);`
`136`	`135`	`r = -errno;`