network: update address infomation even if link is in failed or linger state

yuwata · yuwata · commit ea121d8f2520 · 2020-07-29T02:05:05.000+09:00
As the link may be reconfigured later. If we do not update the address
information, then its setup state or operstate may not be updated
correctly.
diff --git a/src/network/networkd-address.c b/src/network/networkd-address.c
@@ -355,18 +355,18 @@ int address_update(
         int r;
 
         assert(address);
+        assert(address->link);
         assert(cinfo);
-        assert_return(address->link, 1);
-
-        if (IN_SET(address->link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
-                return 1;
 
         ready = address_is_ready(address);
 
         address->flags = flags;
         address->scope = scope;
         address->cinfo = *cinfo;
 
+        if (IN_SET(address->link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+                return 0;
+
         link_update_operstate(address->link, true);
         link_check_ready(address->link);
 
