lgtm: complain about accept() [people should use accept4() instead, due to O_CLOEXEC]

poettering · poettering · commit e2d0fa6feb37 · 2019-04-10T20:03:38.000+02:00
diff --git a/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql b/.lgtm/cpp-queries/PotentiallyDangerousFunction.ql
@@ -41,6 +41,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {
   ) or (
     f.getQualifiedName() = "strerror" and
     message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead."
+  ) or (
+    f.getQualifiedName() = "accept" and
+    message = "Call to accept() is not O_CLOEXEC-safe. Use accept4() instead."
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,9 @@ predicate potentiallyDangerousFunction(Function f, string message) {`
`41`	`41`	`) or (`
`42`	`42`	`f.getQualifiedName() = "strerror" and`
`43`	`43`	`message = "Call to strerror() is not thread-safe. Use strerror_r() or printf()'s %m format string instead."`
	`44`	`+ ) or (`
	`45`	`+ f.getQualifiedName() = "accept" and`
	`46`	`+ message = "Call to accept() is not O_CLOEXEC-safe. Use accept4() instead."`
`44`	`47`	`)`
`45`	`48`	`}`
`46`	`49`