sd-bus: check for potential integer overflow in KDBUS_ITEM_FOREACH()

zonque · zonque · commit b629d0984206 · 2014-03-08T14:18:48.000+01:00
For large values of item-&gt;size, the 'part' pointer can wrap around,
which results in an illegal pointer, but currently passes the for-loop
condition.
diff --git a/src/libsystemd/sd-bus/bus-kernel.h b/src/libsystemd/sd-bus/bus-kernel.h
@@ -31,7 +31,8 @@
 
 #define KDBUS_ITEM_FOREACH(part, head, first)                           \
         for (part = (head)->first;                                      \
-             (uint8_t *)(part) < (uint8_t *)(head) + (head)->size;      \
+             ((uint8_t *)(part) < (uint8_t *)(head) + (head)->size) &&  \
+                ((uint8_t *) part >= (uint8_t *) head);                 \
              part = KDBUS_ITEM_NEXT(part))
 
 #define KDBUS_ITEM_HEADER_SIZE offsetof(struct kdbus_item, data)
