bpf: fix memleak in restrict_fs_bpf

Julia Kartseva · poettering · commit 7ab3c86d63ce · 2021-11-24T09:37:33.000+01:00
Memory allocated in bpf skeleton is not freed. Wrap ptr in _cleanup_. Fixes: systemd#21471
diff --git a/src/core/bpf-lsm.c b/src/core/bpf-lsm.c
@@ -52,7 +52,7 @@ static bool bpf_can_link_lsm_program(struct bpf_program *prog) {
 }
 
 static int prepare_restrict_fs_bpf(struct restrict_fs_bpf **ret_obj) {
-        struct restrict_fs_bpf *obj = 0;
+        _cleanup_(restrict_fs_bpf_freep) struct restrict_fs_bpf *obj = NULL;
         _cleanup_close_ int inner_map_fd = -1;
         int r;
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ static bool bpf_can_link_lsm_program(struct bpf_program *prog) {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`static int prepare_restrict_fs_bpf(struct restrict_fs_bpf **ret_obj) {`
`55`		`- struct restrict_fs_bpf *obj = 0;`
	`55`	`+ _cleanup_(restrict_fs_bpf_freep) struct restrict_fs_bpf *obj = NULL;`
`56`	`56`	`_cleanup_close_ int inner_map_fd = -1;`
`57`	`57`	`int r;`
`58`	`58`