Skip to content

Commit 5a8b164

Browse files
keszybzyuwata
authored andcommitted
meson: drop parens when appending to list
Meson does not care either way, so let's use the simpler syntax. And files() already gives a list, so nesting this in a list wouldn't be necessary even if meson did not flatten everything.
1 parent 48e0e10 commit 5a8b164

File tree

5 files changed

+62
-61
lines changed

5 files changed

+62
-61
lines changed

man/meson.build

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ foreach tuple : xsltproc.found() ? manpages : []
4747
manaliases = []
4848
htmlaliases = []
4949
foreach alias : aliases
50-
manaliases += [alias + '.' + section]
51-
htmlaliases += [alias + '.html']
50+
manaliases += alias + '.' + section
51+
htmlaliases += alias + '.html'
5252
endforeach
5353

5454
mandirn = join_paths(get_option('mandir'), 'man' + section)
@@ -62,7 +62,7 @@ foreach tuple : xsltproc.found() ? manpages : []
6262
depend_files : custom_entities_ent,
6363
install : want_man,
6464
install_dir : mandirn)
65-
man_pages += [p1]
65+
man_pages += p1
6666

6767
p2 = []
6868
foreach htmlalias : htmlaliases
@@ -75,9 +75,9 @@ foreach tuple : xsltproc.found() ? manpages : []
7575
dst = join_paths(docdir, 'html', htmlalias)
7676
cmd = 'ln -fs @0@ $DESTDIR@1@'.format(html, dst)
7777
meson.add_install_script('sh', '-c', cmd)
78-
p2 += [link]
78+
p2 += link
7979
endif
80-
html_pages += [link]
80+
html_pages += link
8181
endforeach
8282

8383
p3 = custom_target(
@@ -89,7 +89,7 @@ foreach tuple : xsltproc.found() ? manpages : []
8989
depends : p2,
9090
install : want_html,
9191
install_dir : join_paths(docdir, 'html'))
92-
html_pages += [p3]
92+
html_pages += p3
9393

9494
source_xml_files += files(tuple[0] + '.xml')
9595
else
@@ -135,7 +135,7 @@ foreach tuple : xsltproc.found() ? [['systemd.directives', '7', systemd_directiv
135135
command : xslt_cmd + [custom_man_xsl, '@INPUT@'],
136136
install : want_man and have_lxml,
137137
install_dir : mandirn)
138-
man_pages += [p1]
138+
man_pages += p1
139139

140140
p2 = []
141141
if html == 'systemd.index.html'
@@ -149,9 +149,9 @@ foreach tuple : xsltproc.found() ? [['systemd.directives', '7', systemd_directiv
149149
dst = join_paths(docdir, 'html', htmlalias)
150150
cmd = 'ln -fs @0@ $DESTDIR@1@'.format(html, dst)
151151
meson.add_install_script('sh', '-c', cmd)
152-
p2 += [link]
152+
p2 += link
153153
endif
154-
html_pages += [link]
154+
html_pages += link
155155
endif
156156

157157
p3 = custom_target(
@@ -163,7 +163,7 @@ foreach tuple : xsltproc.found() ? [['systemd.directives', '7', systemd_directiv
163163
depends : p2,
164164
install : want_html and have_lxml,
165165
install_dir : join_paths(docdir, 'html'))
166-
html_pages += [p3]
166+
html_pages += p3
167167
endforeach
168168

169169
# cannot use run_target until https://github.com/mesonbuild/meson/issues/1644 is resolved

0 commit comments

Comments
 (0)