resolved: make sure we GC stream transactions properly

poettering · poettering · commit 598f44bd2c3b · 2015-12-27T01:41:39.000+01:00
Make sure to GC a transaction after dealing with a reply, even if the
transaction is not complete yet.
diff --git a/src/resolve/resolved-dns-transaction.c b/src/resolve/resolved-dns-transaction.c
@@ -342,6 +342,8 @@ static int on_stream_complete(DnsStream *s, int error) {
         /* If the response wasn't useful, then complete the transition now */
         if (t->state == DNS_TRANSACTION_PENDING)
                 dns_transaction_complete(t, DNS_TRANSACTION_INVALID_REPLY);
+        else
+                dns_transaction_gc(t);
 
         return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -342,6 +342,8 @@ static int on_stream_complete(DnsStream *s, int error) {`
`342`	`342`	`/* If the response wasn't useful, then complete the transition now */`
`343`	`343`	`if (t->state == DNS_TRANSACTION_PENDING)`
`344`	`344`	`dns_transaction_complete(t, DNS_TRANSACTION_INVALID_REPLY);`
	`345`	`+ else`
	`346`	`+ dns_transaction_gc(t);`
`345`	`347`
`346`	`348`	`return 0;`
`347`	`349`	`}`