python: adjust imports, indentation, unused variables following pylint advice

keszybz · keszybz · commit 00d5eaafd133 · 2016-12-01T18:55:23.000-05:00
diff --git a/src/journal-remote/log-generator.py b/src/journal-remote/log-generator.py
@@ -29,7 +29,7 @@
 DATA={data}
 """
 
-m  = 0x198603b12d7
+m = 0x198603b12d7
 realtime_ts = 1404101101501873
 monotonic_ts = 1753961140951
 source_realtime_ts = 1404101101483516
@@ -71,5 +71,5 @@
         print('.', file=sys.stderr, end='', flush=True)
 
 if OPTIONS.dots:
-        print(file=sys.stderr)
+    print(file=sys.stderr)
 print('Wrote {} bytes'.format(bytes), file=sys.stderr)
diff --git a/test/networkd-test.py b/test/networkd-test.py
@@ -153,7 +153,7 @@ def do_test(self, coldplug=True, ipv6=False, extra_opts='',
                 # check iface state and IP 6 address; FIXME: we need to wait a bit
                 # longer, as the iface is "configured" already with IPv4 *or*
                 # IPv6, but we want to wait for both
-                for timeout in range(10):
+                for _ in range(10):
                     out = subprocess.check_output(['ip', 'a', 'show', 'dev', self.iface])
                     if b'state UP' in out and b'inet6 2600' in out and b'inet 192.168' in out:
                         break
@@ -558,7 +558,7 @@ def create_iface(self, ipv6=False, dhcpserver_opts=None):
                                '--service-type=notify', script])
 
         # wait until devices got created
-        for timeout in range(50):
+        for _ in range(50):
             out = subprocess.check_output(['ip', 'a', 'show', 'dev', self.if_router])
             if b'state UP' in out and b'scope global' in out:
                 break
diff --git a/test/sysv-generator-test.py b/test/sysv-generator-test.py
@@ -308,7 +308,7 @@ def test_provides_escaped(self):
         err, results = self.run_generator()
         self.assertEqual(list(results), ['foo.service'])
         self.assertEqual(os.readlink(os.path.join(self.out_dir, 'foo\\x2b.service')),
-                'foo.service')
+                         'foo.service')
         self.assertNotIn('Overwriting', err)
 
     def test_same_provides_in_multiple_scripts(self):
