*: remove interfacer linter from CI

cyphar · cyphar · commit d283c7fa2b93 · 2019-03-13T11:48:39.000+11:00
It has been declared deprecated by the author, and has a knack for
false-positives (as well as giving bad advice when it comes to APIs --
which is quite clear when looking at "nolint: interfacer" comments).

Signed-off-by: Aleksa Sarai &lt;asarai@suse.de&gt;
diff --git a/daemon/container_operations.go b/daemon/container_operations.go
@@ -801,7 +801,7 @@ func (daemon *Daemon) connectToNetwork(container *container.Container, idOrName
 	return nil
 }
 
-func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error { // nolint: interfacer
+func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error {
 	if ep == nil {
 		return errors.New("invalid enppoint whhile building portmap info")
 	}
diff --git a/daemon/metrics.go b/daemon/metrics.go
@@ -143,7 +143,7 @@ type metricsPlugin interface {
 	StopMetrics() error
 }
 
-func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) { // nolint: interfacer
+func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) {
 	if pc, ok := p.(plugingetter.PluginWithV1Client); ok {
 		return &metricsPluginAdapter{pc.Client(), p.Name()}, nil
 	}
diff --git a/distribution/pull_v1.go b/distribution/pull_v1.go
@@ -13,7 +13,6 @@ import (
 	"time"
 
 	"github.com/docker/distribution/reference"
-	"github.com/docker/distribution/registry/client/auth"
 	"github.com/docker/distribution/registry/client/transport"
 	"github.com/docker/docker/distribution/metadata"
 	"github.com/docker/docker/distribution/xfer"
@@ -70,9 +69,7 @@ func (p *v1Puller) Pull(ctx context.Context, ref reference.Named, _ *specs.Platf
 	return nil
 }
 
-// Note use auth.Scope rather than reference.Named due to this warning causing Jenkins CI to fail:
-// warning: ref can be github.com/docker/docker/vendor/github.com/docker/distribution/registry/client/auth.Scope (interfacer)
-func (p *v1Puller) pullRepository(ctx context.Context, ref auth.Scope) error {
+func (p *v1Puller) pullRepository(ctx context.Context, ref reference.Named) error {
 	progress.Message(p.config.ProgressOutput, "", "Pulling repository "+p.repoInfo.Name.Name())
 
 	tagged, isTagged := ref.(reference.NamedTagged)
diff --git a/distribution/push_v2.go b/distribution/push_v2.go
@@ -649,7 +649,6 @@ func (bla byLikeness) Swap(i, j int) {
 }
 func (bla byLikeness) Len() int { return len(bla.arr) }
 
-// nolint: interfacer
 func sortV2MetadataByLikenessAndAge(repoInfo reference.Named, hmacKey []byte, marr []metadata.V2Metadata) {
 	// reverse the metadata array to shift the newest entries to the beginning
 	for i := 0; i < len(marr)/2; i++ {
diff --git a/hack/validate/gometalinter.json b/hack/validate/gometalinter.json
@@ -18,7 +18,6 @@
     "golint",
     "gosimple",
     "ineffassign",
-    "interfacer",
     "unconvert",
     "vet"
   ],
diff --git a/registry/auth.go b/registry/auth.go
@@ -248,7 +248,6 @@ func (err PingResponseError) Error() string {
 // challenge manager for the supported authentication types and
 // whether v2 was confirmed by the response. If a response is received but
 // cannot be interpreted a PingResponseError will be returned.
-// nolint: interfacer
 func PingV2Registry(endpoint *url.URL, transport http.RoundTripper) (challenge.Manager, bool, error) {
 	var (
 		foundV2   = false

Original file line number	Diff line number	Diff line change
`@@ -801,7 +801,7 @@ func (daemon Daemon) connectToNetwork(container container.Container, idOrName`
`801`	`801`	`return nil`
`802`	`802`	`}`
`803`	`803`
`804`		`-func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error { // nolint: interfacer`
	`804`	`+func updateJoinInfo(networkSettings *network.Settings, n libnetwork.Network, ep libnetwork.Endpoint) error {`
`805`	`805`	`if ep == nil {`
`806`	`806`	`return errors.New("invalid enppoint whhile building portmap info")`
`807`	`807`	`}`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ type metricsPlugin interface {`
`143`	`143`	`StopMetrics() error`
`144`	`144`	`}`
`145`	`145`
`146`		`-func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) { // nolint: interfacer`
	`146`	`+func makePluginAdapter(p plugingetter.CompatPlugin) (metricsPlugin, error) {`
`147`	`147`	`if pc, ok := p.(plugingetter.PluginWithV1Client); ok {`
`148`	`148`	`return &metricsPluginAdapter{pc.Client(), p.Name()}, nil`
`149`	`149`	`}`
Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,6 @@ func (bla byLikeness) Swap(i, j int) {`
`649`	`649`	`}`
`650`	`650`	`func (bla byLikeness) Len() int { return len(bla.arr) }`
`651`	`651`
`652`		`-// nolint: interfacer`
`653`	`652`	`func sortV2MetadataByLikenessAndAge(repoInfo reference.Named, hmacKey []byte, marr []metadata.V2Metadata) {`
`654`	`653`	`// reverse the metadata array to shift the newest entries to the beginning`
`655`	`654`	`for i := 0; i < len(marr)/2; i++ {`