Skip to content

Commit bc57687

Browse files
committed
Fix flaky unit test
Fix flaky test `TestHTTPTimeout` caused by precision problem. Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
1 parent d93a62e commit bc57687

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/plugins/client_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ func testHTTPTimeout(t *testing.T, timeout, epsilon time.Duration) {
4747
t.Fatalf("The request should be canceled %v", err)
4848
}
4949
elapsed := time.Now().Sub(begin)
50-
if elapsed < timeout || elapsed > timeout+epsilon {
50+
if elapsed < timeout-epsilon || elapsed > timeout+epsilon {
5151
t.Fatalf("elapsed time: got %v, expected %v (epsilon=%v)",
5252
elapsed, timeout, epsilon)
5353
}
5454
}
5555

5656
func TestHTTPTimeout(t *testing.T) {
57-
testHTTPTimeout(t, 5*time.Second, 1*time.Second)
57+
testHTTPTimeout(t, 5*time.Second, 500*time.Millisecond)
5858
}
5959

6060
func TestFailedConnection(t *testing.T) {

0 commit comments

Comments
 (0)