Remove unused id field from Builder.

dnephin · dnephin · commit a6abd57b83dc · 2017-04-11T14:44:32.000-04:00
Signed-off-by: Daniel Nephin &lt;dnephin@docker.com&gt;
diff --git a/api/types/backend/backend.go b/api/types/backend/backend.go
@@ -100,8 +100,7 @@ type ContainerCommitConfig struct {
 	Changes []string
 }
 
-// ProgressWriter is an interface
-// to transport progress streams.
+// ProgressWriter is a data object to transport progress streams to the client
 type ProgressWriter struct {
 	Output             io.Writer
 	StdoutFormatter    *streamformatter.StdoutFormatter
diff --git a/builder/dockerfile/builder.go b/builder/dockerfile/builder.go
@@ -65,9 +65,6 @@ type Builder struct {
 	buildArgs     *buildArgs
 	directive     parser.Directive
 
-	// TODO: remove once docker.Commit can receive a tag
-	id string
-
 	imageCache builder.ImageCache
 	from       builder.Image
 }
@@ -127,7 +124,6 @@ func NewBuilder(clientCtx context.Context, config *types.ImageBuildOptions, back
 		context:       buildContext,
 		runConfig:     new(container.Config),
 		tmpContainers: map[string]struct{}{},
-		id:            stringid.GenerateNonCryptoID(),
 		buildArgs:     newBuildArgs(config.BuildArgs),
 		directive: parser.Directive{
 			EscapeSeen:           false,

Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,7 @@ type ContainerCommitConfig struct {`
`100`	`100`	`Changes []string`
`101`	`101`	`}`
`102`	`102`
`103`		`-// ProgressWriter is an interface`
`104`		`-// to transport progress streams.`
	`103`	`+// ProgressWriter is a data object to transport progress streams to the client`
`105`	`104`	`type ProgressWriter struct {`
`106`	`105`	`Output io.Writer`
`107`	`106`	`StdoutFormatter *streamformatter.StdoutFormatter`