Skip to content

Commit 89c6feb

Browse files
committed
Dockerd won't start if a network with the default subnet prefix already exists in HNS.
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
1 parent c36460c commit 89c6feb

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

daemon/daemon_windows.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import (
3333

3434
const (
3535
isWindows = true
36-
defaultNetworkSpace = "172.16.0.0/12"
3736
platformSupported = true
3837
windowsMinCPUShares = 1
3938
windowsMaxCPUShares = 10000
@@ -424,15 +423,19 @@ func initBridgeDriver(controller libnetwork.NetworkController, config *config.Co
424423
winlibnetwork.NetworkName: runconfig.DefaultDaemonNetworkMode().NetworkName(),
425424
}
426425

427-
subnetPrefix := defaultNetworkSpace
426+
var ipamOption libnetwork.NetworkOption
427+
var subnetPrefix string
428+
428429
if config.BridgeConfig.FixedCIDR != "" {
429430
subnetPrefix = config.BridgeConfig.FixedCIDR
430431
}
431432

432-
ipamV4Conf := libnetwork.IpamConf{PreferredPool: subnetPrefix}
433-
v4Conf := []*libnetwork.IpamConf{&ipamV4Conf}
434-
v6Conf := []*libnetwork.IpamConf{}
435-
ipamOption := libnetwork.NetworkOptionIpam("default", "", v4Conf, v6Conf, nil)
433+
if subnetPrefix != "" {
434+
ipamV4Conf := libnetwork.IpamConf{PreferredPool: subnetPrefix}
435+
v4Conf := []*libnetwork.IpamConf{&ipamV4Conf}
436+
v6Conf := []*libnetwork.IpamConf{}
437+
ipamOption = libnetwork.NetworkOptionIpam("default", "", v4Conf, v6Conf, nil)
438+
}
436439

437440
_, err := controller.NewNetwork(string(runconfig.DefaultDaemonNetworkMode()), runconfig.DefaultDaemonNetworkMode().NetworkName(), "",
438441
libnetwork.NetworkOptionGeneric(options.Generic{

0 commit comments

Comments
 (0)