Merge pull request moby#15393 from azurezk/exportImage-toplevel

Jessie Frazelle · Jessie Frazelle · commit 82e2dec06de6 · 2015-08-24T14:35:55.000-07:00
change exportImage to top-level func
diff --git a/graph/export.go b/graph/export.go
@@ -105,7 +105,6 @@ func (s *TagStore) ImageExport(names []string, outStream io.Writer) error {
 	return nil
 }
 
-// FIXME: this should be a top-level function, not a class method
 func (s *TagStore) exportImage(name, tempdir string) error {
 	for n := name; n != ""; {
 		// temporary directory
diff --git a/pkg/parsers/parsers.go b/pkg/parsers/parsers.go
@@ -14,7 +14,6 @@ import (
 
 // ParseHost parses the specified address and returns an address that will be used as the host.
 // Depending of the address specified, will use the defaultTCPAddr or defaultUnixAddr
-// FIXME: Change this not to receive default value as parameter
 func ParseHost(defaultTCPAddr, defaultUnixAddr, addr string) (string, error) {
 	addr = strings.TrimSpace(addr)
 	if addr == "" {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ func (s *TagStore) ImageExport(names []string, outStream io.Writer) error {`
`105`	`105`	`return nil`
`106`	`106`	`}`
`107`	`107`
`108`		`-// FIXME: this should be a top-level function, not a class method`
`109`	`108`	`func (s *TagStore) exportImage(name, tempdir string) error {`
`110`	`109`	`for n := name; n != ""; {`
`111`	`110`	`// temporary directory`