Skip to content

Commit 736e93a

Browse files
committed
Remove testing logrus output from ppc64le
This removes two tests on ppc64le. There is an old bug with a syscall on power moby#8653, that causes logrus to default to using logfmt. These two tests look for logrus format specific strings, and fail if they don't see it. Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>
1 parent f5ed72c commit 736e93a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

integration-cli/docker_cli_daemon_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2068,7 +2068,7 @@ func (s *DockerDaemonSuite) TestRunLinksChanged(c *check.C) {
20682068
}
20692069

20702070
func (s *DockerDaemonSuite) TestDaemonStartWithoutColors(c *check.C) {
2071-
testRequires(c, DaemonIsLinux)
2071+
testRequires(c, DaemonIsLinux, NotPpc64le)
20722072
newD := NewDaemon(c)
20732073

20742074
infoLog := "\x1b[34mINFO\x1b"
@@ -2097,7 +2097,7 @@ func (s *DockerDaemonSuite) TestDaemonStartWithoutColors(c *check.C) {
20972097
}
20982098

20992099
func (s *DockerDaemonSuite) TestDaemonDebugLog(c *check.C) {
2100-
testRequires(c, DaemonIsLinux)
2100+
testRequires(c, DaemonIsLinux, NotPpc64le)
21012101
newD := NewDaemon(c)
21022102

21032103
debugLog := "\x1b[37mDEBU\x1b"

integration-cli/requirements.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ var (
3333
func() bool { return os.Getenv("DOCKER_ENGINE_GOARCH") != "arm" },
3434
"Test requires a daemon not running on ARM",
3535
}
36+
NotPpc64le = testRequirement{
37+
func() bool { return os.Getenv("DOCKER_ENGINE_GOARCH") != "ppc64le" },
38+
"Test requires a daemon not running on ppc64le",
39+
}
3640
SameHostDaemon = testRequirement{
3741
func() bool { return isLocalDaemon },
3842
"Test requires docker daemon to run on the same machine as CLI",

0 commit comments

Comments
 (0)