Make error message consistent when removing containers fail.

calavera · calavera · commit 50de9fdff110 · 2016-02-01T15:32:50.000-05:00
Signed-off-by: David Calavera &lt;david.calavera@gmail.com&gt;
diff --git a/api/client/rm.go b/api/client/rm.go
@@ -28,15 +28,8 @@ func (cli *DockerCli) CmdRm(args ...string) error {
 		}
 		name = strings.Trim(name, "/")
 
-		options := types.ContainerRemoveOptions{
-			ContainerID:   name,
-			RemoveVolumes: *v,
-			RemoveLinks:   *link,
-			Force:         *force,
-		}
-
-		if err := cli.client.ContainerRemove(options); err != nil {
-			errs = append(errs, fmt.Sprintf("Failed to remove container (%s): %s", name, err))
+		if err := cli.removeContainer(name, *v, *link, *force); err != nil {
+			errs = append(errs, err.Error())
 		} else {
 			fmt.Fprintf(cli.out, "%s\n", name)
 		}
@@ -46,3 +39,16 @@ func (cli *DockerCli) CmdRm(args ...string) error {
 	}
 	return nil
 }
+
+func (cli *DockerCli) removeContainer(containerID string, removeVolumes, removeLinks, force bool) error {
+	options := types.ContainerRemoveOptions{
+		ContainerID:   containerID,
+		RemoveVolumes: removeVolumes,
+		RemoveLinks:   removeLinks,
+		Force:         force,
+	}
+	if err := cli.client.ContainerRemove(options); err != nil {
+		return fmt.Errorf("Failed to remove container (%s): %v", containerID, err)
+	}
+	return nil
+}
diff --git a/api/client/run.go b/api/client/run.go
@@ -218,17 +218,13 @@ func (cli *DockerCli) CmdRun(args ...string) error {
 		})
 	}
 
-	defer func() {
-		if *flAutoRemove {
-			options := types.ContainerRemoveOptions{
-				ContainerID:   createResponse.ID,
-				RemoveVolumes: true,
-			}
-			if err := cli.client.ContainerRemove(options); err != nil {
-				fmt.Fprintf(cli.err, "Error deleting container: %s\n", err)
+	if *flAutoRemove {
+		defer func() {
+			if err := cli.removeContainer(createResponse.ID, true, false, false); err != nil {
+				fmt.Fprintf(cli.err, "%v\n", err)
 			}
-		}
-	}()
+		}()
+	}
 
 	//start the container
 	if err := cli.client.ContainerStart(createResponse.ID); err != nil {
