Warning out when disalbe oom killer but not set the memory limit

HuKeping · HuKeping · commit 3aa70c1948e4 · 2015-10-26T11:33:51.000+08:00
It is always the best practice that only disable the OOM Killer where
you also set the `-m/--memory` option, otherwise it's dangerous.

Signed-off-by: Hu Keping &lt;hukeping@huawei.com&gt;
diff --git a/api/client/run.go b/api/client/run.go
@@ -63,6 +63,10 @@ func (cli *DockerCli) CmdRun(args ...string) error {
 		os.Exit(1)
 	}
 
+	if hostConfig.OomKillDisable && hostConfig.Memory == 0 {
+		fmt.Fprintf(cli.err, "WARNING: Dangerous only disable the OOM Killer on containers but not set the '-m/--memory' option\n")
+	}
+
 	if len(hostConfig.DNS) > 0 {
 		// check the DNS settings passed via --dns against
 		// localhost regexp to warn if they are trying to
