Fixing moby#24631, inspect output on swarm object types without labels is empty object {}

adshmh · adshmh · commit 1b347cfc7954 · 2017-02-15T01:25:55.000-05:00
Signed-off-by: Arash Deshmeh &lt;adeshmeh@ca.ibm.com&gt;
diff --git a/api/types/swarm/common.go b/api/types/swarm/common.go
@@ -17,7 +17,7 @@ type Meta struct {
 // Annotations represents how to describe an object.
 type Annotations struct {
 	Name   string            `json:",omitempty"`
-	Labels map[string]string `json:",omitempty"`
+	Labels map[string]string `json:"Labels"`
 }
 
 // Driver represents a driver (network, logging).
diff --git a/daemon/cluster/convert/network.go b/daemon/cluster/convert/network.go
@@ -39,8 +39,7 @@ func networkFromGRPC(n *swarmapi.Network) types.Network {
 		network.UpdatedAt, _ = gogotypes.TimestampFromProto(n.Meta.UpdatedAt)
 
 		//Annotations
-		network.Spec.Name = n.Spec.Annotations.Name
-		network.Spec.Labels = n.Spec.Annotations.Labels
+		network.Spec.Annotations = annotationsFromGRPC(n.Spec.Annotations)
 
 		//DriverConfiguration
 		if n.Spec.DriverConfig != nil {
diff --git a/daemon/cluster/convert/node.go b/daemon/cluster/convert/node.go
@@ -30,8 +30,7 @@ func NodeFromGRPC(n swarmapi.Node) types.Node {
 	node.UpdatedAt, _ = gogotypes.TimestampFromProto(n.Meta.UpdatedAt)
 
 	//Annotations
-	node.Spec.Name = n.Spec.Annotations.Name
-	node.Spec.Labels = n.Spec.Annotations.Labels
+	node.Spec.Annotations = annotationsFromGRPC(n.Spec.Annotations)
 
 	//Description
 	if n.Description != nil {
diff --git a/daemon/cluster/convert/secret.go b/daemon/cluster/convert/secret.go
@@ -11,11 +11,8 @@ func SecretFromGRPC(s *swarmapi.Secret) swarmtypes.Secret {
 	secret := swarmtypes.Secret{
 		ID: s.ID,
 		Spec: swarmtypes.SecretSpec{
-			Annotations: swarmtypes.Annotations{
-				Name:   s.Spec.Annotations.Name,
-				Labels: s.Spec.Annotations.Labels,
-			},
-			Data: s.Spec.Data,
+			Annotations: annotationsFromGRPC(s.Spec.Annotations),
+			Data:        s.Spec.Data,
 		},
 	}
 
diff --git a/daemon/cluster/convert/service.go b/daemon/cluster/convert/service.go
@@ -70,11 +70,7 @@ func serviceSpecFromGRPC(spec *swarmapi.ServiceSpec) *types.ServiceSpec {
 
 	containerConfig := spec.Task.Runtime.(*swarmapi.TaskSpec_Container).Container
 	convertedSpec := &types.ServiceSpec{
-		Annotations: types.Annotations{
-			Name:   spec.Annotations.Name,
-			Labels: spec.Annotations.Labels,
-		},
-
+		Annotations: annotationsFromGRPC(spec.Annotations),
 		TaskTemplate: types.TaskSpec{
 			ContainerSpec: containerSpecFromGRPC(containerConfig),
 			Resources:     resourcesFromGRPC(spec.Task.Resources),
@@ -236,6 +232,19 @@ func ServiceSpecToGRPC(s types.ServiceSpec) (swarmapi.ServiceSpec, error) {
 	return spec, nil
 }
 
+func annotationsFromGRPC(ann swarmapi.Annotations) types.Annotations {
+	a := types.Annotations{
+		Name:   ann.Name,
+		Labels: ann.Labels,
+	}
+
+	if a.Labels == nil {
+		a.Labels = make(map[string]string)
+	}
+
+	return a
+}
+
 func resourcesFromGRPC(res *swarmapi.ResourceRequirements) *types.ResourceRequirements {
 	var resources *types.ResourceRequirements
 	if res != nil {
diff --git a/daemon/cluster/convert/swarm.go b/daemon/cluster/convert/swarm.go
@@ -56,8 +56,7 @@ func SwarmFromGRPC(c swarmapi.Cluster) types.Swarm {
 	swarm.UpdatedAt, _ = gogotypes.TimestampFromProto(c.Meta.UpdatedAt)
 
 	// Annotations
-	swarm.Spec.Name = c.Spec.Annotations.Name
-	swarm.Spec.Labels = c.Spec.Annotations.Labels
+	swarm.Spec.Annotations = annotationsFromGRPC(c.Spec.Annotations)
 
 	return swarm
 }
diff --git a/daemon/cluster/convert/task.go b/daemon/cluster/convert/task.go
@@ -21,14 +21,11 @@ func TaskFromGRPC(t swarmapi.Task) types.Task {
 	}
 
 	task := types.Task{
-		ID: t.ID,
-		Annotations: types.Annotations{
-			Name:   t.Annotations.Name,
-			Labels: t.Annotations.Labels,
-		},
-		ServiceID: t.ServiceID,
-		Slot:      int(t.Slot),
-		NodeID:    t.NodeID,
+		ID:          t.ID,
+		Annotations: annotationsFromGRPC(t.Annotations),
+		ServiceID:   t.ServiceID,
+		Slot:        int(t.Slot),
+		NodeID:      t.NodeID,
 		Spec: types.TaskSpec{
 			ContainerSpec: containerSpecFromGRPC(containerConfig),
 			Resources:     resourcesFromGRPC(t.Spec.Resources),

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ type Meta struct {`
`17`	`17`	`// Annotations represents how to describe an object.`
`18`	`18`	`type Annotations struct {`
`19`	`19`	Name string `json:",omitempty"`
`20`		- Labels map[string]string `json:",omitempty"`
	`20`	+ Labels map[string]string `json:"Labels"`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`// Driver represents a driver (network, logging).`
Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,7 @@ func SwarmFromGRPC(c swarmapi.Cluster) types.Swarm {`
`56`	`56`	`swarm.UpdatedAt, _ = gogotypes.TimestampFromProto(c.Meta.UpdatedAt)`
`57`	`57`
`58`	`58`	`// Annotations`
`59`		`- swarm.Spec.Name = c.Spec.Annotations.Name`
`60`		`- swarm.Spec.Labels = c.Spec.Annotations.Labels`
	`59`	`+ swarm.Spec.Annotations = annotationsFromGRPC(c.Spec.Annotations)`
`61`	`60`
`62`	`61`	`return swarm`
`63`	`62`	`}`