Merge pull request moby#14578 from mountkin/fix-rmi-image-not-found

calavera · calavera · commit 15cb7dfc9ecb · 2015-07-16T18:02:51.000-07:00
don't allow deleting the image of running containers
diff --git a/daemon/image_delete.go b/daemon/image_delete.go
@@ -151,7 +151,7 @@ func (daemon *Daemon) canDeleteImage(imgID string, force bool) error {
 		parent, err := daemon.Repositories().LookupImage(container.ImageID)
 		if err != nil {
 			if daemon.Graph().IsNotExist(err, container.ImageID) {
-				return nil
+				continue
 			}
 			return err
 		}
diff --git a/integration-cli/docker_cli_rmi_test.go b/integration-cli/docker_cli_rmi_test.go
@@ -249,3 +249,29 @@ func (s *DockerSuite) TestRmiBlank(c *check.C) {
 		c.Fatalf("Expected error message not generated: %s", out)
 	}
 }
+
+func (s *DockerSuite) TestRmiContainerImageNotFound(c *check.C) {
+	// Build 2 images for testing.
+	imageNames := []string{"test1", "test2"}
+	imageIds := make([]string, 2)
+	for i, name := range imageNames {
+		dockerfile := fmt.Sprintf("FROM busybox\nMAINTAINER %s\nRUN echo %s\n", name, name)
+		id, err := buildImage(name, dockerfile, false)
+		c.Assert(err, check.IsNil)
+		imageIds[i] = id
+	}
+
+	// Create a long-running container.
+	dockerCmd(c, "run", "-d", imageNames[0], "top")
+
+	// Create a stopped container, and then force remove its image.
+	dockerCmd(c, "run", imageNames[1], "true")
+	dockerCmd(c, "rmi", "-f", imageIds[1])
+
+	// Try to remove the image of the running container and see if it fails as expected.
+	out, _, err := dockerCmdWithError(c, "rmi", "-f", imageIds[0])
+	if err == nil || !strings.Contains(out, "is using it") {
+		c.Log(out)
+		c.Fatal("The image of the running container should not be removed.")
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ func (daemon *Daemon) canDeleteImage(imgID string, force bool) error {`
`151`	`151`	`parent, err := daemon.Repositories().LookupImage(container.ImageID)`
`152`	`152`	`if err != nil {`
`153`	`153`	`if daemon.Graph().IsNotExist(err, container.ImageID) {`
`154`		`- return nil`
	`154`	`+ continue`
`155`	`155`	`}`
`156`	`156`	`return err`
`157`	`157`	`}`