Reduce TestClientWithRequestTimeout flakiness

thaJeztah · thaJeztah · commit 00a4f67ddf78 · 2021-06-29T23:53:23.000+02:00
The test sometimes failed because no error was returned:

    === Failed
    === FAIL: pkg/plugins TestClientWithRequestTimeout (0.00s)
         client_test.go:254: assertion failed: expected an error, got nil: expected error

Possibly caused by a race condition, as the sleep was just 1 ms longer than the timeout;
this patch is increasing the sleep in the response to try to reduce flakiness.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/pkg/plugins/client_test.go b/pkg/plugins/client_test.go
@@ -242,7 +242,7 @@ func TestClientWithRequestTimeout(t *testing.T) {
 
 	timeout := 1 * time.Millisecond
 	testHandler := func(w http.ResponseWriter, r *http.Request) {
-		time.Sleep(timeout + 1*time.Millisecond)
+		time.Sleep(timeout + 10*time.Millisecond)
 		w.WriteHeader(http.StatusOK)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ func TestClientWithRequestTimeout(t *testing.T) {`
`242`	`242`
`243`	`243`	`timeout := 1 * time.Millisecond`
`244`	`244`	`testHandler := func(w http.ResponseWriter, r *http.Request) {`
`245`		`- time.Sleep(timeout + 1*time.Millisecond)`
	`245`	`+ time.Sleep(timeout + 10*time.Millisecond)`
`246`	`246`	`w.WriteHeader(http.StatusOK)`
`247`	`247`	`}`
`248`	`248`