FIX 2510 Support DNS names

dgageot · dgageot · commit eeb568fd270c · 2015-12-08T10:11:33.000+01:00
Signed-off-by: David Gageot &lt;david@gageot.net&gt;
diff --git a/libmachine/drivers/base.go b/libmachine/drivers/base.go
@@ -2,8 +2,6 @@ package drivers
 
 import (
 	"errors"
-	"fmt"
-	"net"
 	"path/filepath"
 )
 
@@ -41,10 +39,6 @@ func (d *BaseDriver) GetIP() (string, error) {
 	if d.IPAddress == "" {
 		return "", errors.New("IP address is not set")
 	}
-	ip := net.ParseIP(d.IPAddress)
-	if ip == nil {
-		return "", fmt.Errorf("IP address is invalid: %s", d.IPAddress)
-	}
 	return d.IPAddress, nil
 }
 
diff --git a/libmachine/drivers/base_test.go b/libmachine/drivers/base_test.go
@@ -2,7 +2,6 @@ package drivers
 
 import (
 	"errors"
-	"fmt"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -18,7 +17,7 @@ func TestIP(t *testing.T) {
 		{&BaseDriver{IPAddress: "2001:4860:0:2001::68"}, "2001:4860:0:2001::68", nil},
 		{&BaseDriver{IPAddress: "192.168.0.1"}, "192.168.0.1", nil},
 		{&BaseDriver{IPAddress: "::1"}, "::1", nil},
-		{&BaseDriver{IPAddress: "whatever"}, "", fmt.Errorf("IP address is invalid: %s", "whatever")},
+		{&BaseDriver{IPAddress: "hostname"}, "hostname", nil},
 	}
 
 	for _, c := range cases {

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@ package drivers`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"errors"`
`5`		`- "fmt"`
`6`		`- "net"`
`7`	`5`	`"path/filepath"`
`8`	`6`	`)`
`9`	`7`
`@@ -41,10 +39,6 @@ func (d *BaseDriver) GetIP() (string, error) {`
`41`	`39`	`if d.IPAddress == "" {`
`42`	`40`	`return "", errors.New("IP address is not set")`
`43`	`41`	`}`
`44`		`- ip := net.ParseIP(d.IPAddress)`
`45`		`- if ip == nil {`
`46`		`- return "", fmt.Errorf("IP address is invalid: %s", d.IPAddress)`
`47`		`- }`
`48`	`42`	`return d.IPAddress, nil`
`49`	`43`	`}`
`50`	`44`