Skip to content

Commit e466ee9

Browse files
committed
Fix infinite loop when deleting machine in ultra weird state
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
1 parent 291533a commit e466ee9

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

drivers/virtualbox/virtualbox.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -615,22 +615,16 @@ func (d *Driver) Kill() error {
615615
}
616616

617617
func (d *Driver) Remove() error {
618-
s, err := d.GetState()
618+
_, err := d.GetState()
619619
if err != nil {
620620
if err == ErrMachineNotExist {
621621
log.Infof("machine does not exist, assuming it has been removed already")
622622
return nil
623623
}
624624
return err
625625
}
626-
if s == state.Running {
627-
if err := d.Stop(); err != nil {
628-
return err
629-
}
630-
} else if s != state.Stopped {
631-
if err := d.Kill(); err != nil {
632-
return err
633-
}
626+
if err := d.Kill(); err != nil {
627+
return err
634628
}
635629
// vbox will not release it's lock immediately after the stop
636630
d.sleeper.Sleep(1 * time.Second)

0 commit comments

Comments
 (0)