cmd/objdump: reference tracking bug in TestDisasmCode skip message

tklauser · tklauser · commit aab0280476c0 · 2019-12-04T14:53:20.000Z
Issue golang#12559 was closed and split into golang#19158 for mips{,le} and golang#19156 for mips64{,le}. Instead of referencing the individual GOARCH-specific issues in the skip test messages of TestDisasmCode use the tracking bug Change-Id: I6929d25f4ec5aef4f069b7692c4e29106088ce65 Reviewed-on: https://go-review.googlesource.com/c/go/+/209817 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go
@@ -176,10 +176,8 @@ func TestDisasm(t *testing.T) {
 
 func TestDisasmCode(t *testing.T) {
 	switch runtime.GOARCH {
-	case "mips", "mipsle", "mips64", "mips64le":
-		t.Skipf("skipping on %s, issue 12559", runtime.GOARCH)
-	case "s390x":
-		t.Skipf("skipping on %s, issue 15255", runtime.GOARCH)
+	case "mips", "mipsle", "mips64", "mips64le", "s390x":
+		t.Skipf("skipping on %s, issue 19160", runtime.GOARCH)
 	}
 	testDisasm(t, true)
 }

Original file line number	Diff line number	Diff line change
`@@ -176,10 +176,8 @@ func TestDisasm(t *testing.T) {`
`176`	`176`
`177`	`177`	`func TestDisasmCode(t *testing.T) {`
`178`	`178`	`switch runtime.GOARCH {`
`179`		`- case "mips", "mipsle", "mips64", "mips64le":`
`180`		`- t.Skipf("skipping on %s, issue 12559", runtime.GOARCH)`
`181`		`- case "s390x":`
`182`		`- t.Skipf("skipping on %s, issue 15255", runtime.GOARCH)`
	`179`	`+ case "mips", "mipsle", "mips64", "mips64le", "s390x":`
	`180`	`+ t.Skipf("skipping on %s, issue 19160", runtime.GOARCH)`
`183`	`181`	`}`
`184`	`182`	`testDisasm(t, true)`
`185`	`183`	`}`