misc/chrome/gophertool: lower CL number's lower bound and fix input focus on Mac

minux · minux · commit 6dfe0162a659 · 2012-05-17T04:22:44.000+08:00
As our CL number could be as small as 152046, changed CL number's lower bound to 150000. Hopefully our issue count won't reach 150000 any time soon. Chrome on Mac OS X has very strange behavior regarding the focus, although we force the focus to the input box on load, the page still come up with focus on "issue". Set the tabindex of the input box as a workaround. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6212055
diff --git a/misc/chrome/gophertool/gopher.js b/misc/chrome/gophertool/gopher.js
@@ -12,7 +12,7 @@ function urlForInput(t) {
     }
 
     if (numericRE.test(t)) {
-        if (t < 1000000) {
+        if (t < 150000) {
             return "http://code.google.com/p/go/issues/detail?id=" + t;
         }
         return "http://codereview.appspot.com/" + t + "/";
diff --git a/misc/chrome/gophertool/popup.html b/misc/chrome/gophertool/popup.html
@@ -48,7 +48,7 @@
 <a href="#" onclick="openURL('http://codereview.appspot.com/')">codereview</a>,
 <a href="#" onclick="openURL('http://code.google.com/p/go/source/list')">commit</a>, or
 <a href="#" onclick="openURL('http://golang.org/pkg/')">pkg</a> id/name:</small>
-<form style='margin: 0' onsubmit="return navigate();"><nobr><input id="inputbox" size=10 /><input type="submit" value="go" /></nobr></form>
+<form style='margin: 0' onsubmit="return navigate();"><nobr><input id="inputbox" size=10 tabindex=1 /><input type="submit" value="go" /></nobr></form>
 <small>Also: <a href="#" onclick="openURL('http://build.golang.org/')">buildbots</small>
 </body>
 </html>

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ function urlForInput(t) {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`if (numericRE.test(t)) {`
`15`		`- if (t < 1000000) {`
	`15`	`+ if (t < 150000) {`
`16`	`16`	`return "http://code.google.com/p/go/issues/detail?id=" + t;`
`17`	`17`	`}`
`18`	`18`	`return "http://codereview.appspot.com/" + t + "/";`