cmd/gc: reject use of ... with multiple-valued expressions.

remyoudompheng · remyoudompheng · commit 656b192c1672 · 2012-07-13T08:05:41.000+02:00
Fixes golang#3334. R=golang-dev, r CC=golang-dev, remy https://golang.org/cl/6350103
diff --git a/src/cmd/gc/typecheck.c b/src/cmd/gc/typecheck.c
@@ -929,7 +929,7 @@ typecheck1(Node **np, int top)
 			goto doconv;
 		}
 
-		if(count(n->list) == 1)
+		if(count(n->list) == 1 && !n->isddd)
 			typecheck(&n->list->n, Erv | Efnstruct);
 		else
 			typechecklist(n->list, Erv);
diff --git a/test/ddd1.go b/test/ddd1.go
@@ -22,6 +22,16 @@ var (
 	_ = sum([]int{1}) // ERROR "\[\]int literal.*as type int|incompatible"
 )
 
+func sum3(int, int, int) int { return 0 }
+func tuple() (int, int, int) { return 1, 2, 3 }
+
+var (
+	_ = sum(tuple())
+	_ = sum(tuple()...) // ERROR "multiple-value"
+	_ = sum3(tuple())
+	_ = sum3(tuple()...) // ERROR "multiple-value" "not enough"
+)
+
 type T []T
 
 func funny(args ...T) int { return 0 }

Original file line number	Diff line number	Diff line change
`@@ -929,7 +929,7 @@ typecheck1(Node **np, int top)`
`929`	`929`	`goto doconv;`
`930`	`930`	`}`
`931`	`931`
`932`		`- if(count(n->list) == 1)`
	`932`	`+ if(count(n->list) == 1 && !n->isddd)`
`933`	`933`	`typecheck(&n->list->n, Erv \| Efnstruct);`
`934`	`934`	`else`
`935`	`935`	`typechecklist(n->list, Erv);`