Skip to content

Commit 3fafe2e

Browse files
dvyukovdvyukov
committed
internal/trace: support parsing of 1.5 traces
1. Parse out version from trace header. 2. Restore handling of 1.5 traces. 3. Restore optional symbolization of traces. 4. Add some canned 1.5 traces for regression testing (http benchmark trace, runtime/trace stress traces, plus one with broken timestamps). Change-Id: Idb18a001d03ded8e13c2730eeeb37c5836e31256 Reviewed-on: https://go-review.googlesource.com/21803 Run-TryBot: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
1 parent b04e145 commit 3fafe2e

File tree

10 files changed

+295
-92
lines changed

10 files changed

+295
-92
lines changed

‎misc/nacl/testzip.proto‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ go src=..
109109
png
110110
testdata
111111
+
112+
internal
113+
trace
114+
testdata
115+
+
112116
io
113117
+
114118
mime

‎src/cmd/trace/main.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func parseEvents() ([]*trace.Event, error) {
9999
defer tracef.Close()
100100

101101
// Parse and symbolize.
102-
events, err := trace.Parse(bufio.NewReader(tracef))
102+
events, err := trace.Parse(bufio.NewReader(tracef), programBinary)
103103
if err != nil {
104104
loader.err = fmt.Errorf("failed to parse trace: %v", err)
105105
return

0 commit comments

Comments
 (0)