cmd/internal/obj: stay consistent by defining loop variable outside loop header

leonklingele · bradfitz · commit 337a1bde026f · 2019-03-02T05:48:42.000Z
Change-Id: Ieb0ae01cf393c4983e809ce95fedeaa854d19a99 GitHub-Last-Rev: 908f756 GitHub-Pull-Request: golang#30004 Reviewed-on: https://go-review.googlesource.com/c/160428 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
diff --git a/src/cmd/internal/obj/objfile.go b/src/cmd/internal/obj/objfile.go
@@ -252,7 +252,7 @@ func (w *objWriter) writeSymDebug(s *LSym) {
 	for i := 0; i < len(s.P); i += 16 {
 		fmt.Fprintf(ctxt.Bso, "\t%#04x", uint(i))
 		j := i
-		for j = i; j < i+16 && j < len(s.P); j++ {
+		for ; j < i+16 && j < len(s.P); j++ {
 			fmt.Fprintf(ctxt.Bso, " %02x", s.P[j])
 		}
 		for ; j < i+16; j++ {

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ func (w objWriter) writeSymDebug(s LSym) {`
`252`	`252`	`for i := 0; i < len(s.P); i += 16 {`
`253`	`253`	`fmt.Fprintf(ctxt.Bso, "\t%#04x", uint(i))`
`254`	`254`	`j := i`
`255`		`- for j = i; j < i+16 && j < len(s.P); j++ {`
	`255`	`+ for ; j < i+16 && j < len(s.P); j++ {`
`256`	`256`	`fmt.Fprintf(ctxt.Bso, " %02x", s.P[j])`
`257`	`257`	`}`
`258`	`258`	`for ; j < i+16; j++ {`